On Fri 2013-04-05 16:13:12 -0400, Daniel Kahn Gillmor wrote: > On Thu 2013-04-04 11:23:42 -0400, W. Martin Borgert wrote: >> If you have an idea about solving #704607 without introducing a >> new (better said: old) jQuery package, this would be great. Maybe >> we need to backport some JavaScript code from 1.0.1 to 0.12.5. >> (Or we need foreports.debian.org, which would contain older >> software versions for newer Debian releases.) > > heh. i think finding and backporting a fix to the jquery would probably > be the best idea. i'll try to replicate this problem and see what i can > find in the relevant code.
i think i just found this and resolved it. The transition to git is
already paying off :)
I created a throwaway trac instance and verified that the problem was
happening. looking at the list of javascript files being used (via
iceweasel's built-in javascript debugger), i saw "blame.js" which seemed
to be a likely suspect for this specific functionality.
To see what changed, i did:
0 dkg@alice:/tmp/trac$ git diff wheezy master -- trac/htdocs/js/blame.js
diff --git a/trac/htdocs/js/blame.js b/trac/htdocs/js/blame.js
index 4879909..ff50eef 100644
--- a/trac/htdocs/js/blame.js
+++ b/trac/htdocs/js/blame.js
@@ -93,7 +93,7 @@
message.find("div.inlinebuttons").next().css("clear", "right");
show();
- });
+ }, 'html');
} else if (message_is_visible) {
hide();
} else {
0 dkg@alice:/tmp/trac$
then i went to look up this line in upstream:
http://trac.edgewall.org/browser/trunk/trac/htdocs/js/blame.js?annotate=blame#L96
This brought me to http://trac.edgewall.org/changeset/10593
I included that whole 2-line changeset in debian/patches, rebuilt the
package, and tested with the same throwaway trac instance; it works fine
now, so 0.12.5-3 is on its way into unstable.
--dkg
pgp3T48zNoE2a.pgp
Description: PGP signature
