On dom, mar 10, 2013 at 02:41:32 -0500, Jeff Epler wrote: > Package: valgrind > Version: 1:3.8.1-2.1 > Severity: wishlist > Tags: upstream patch > > Dear Maintainer, > I have rebased and minimized FreeBSD's patches for valgrind, and added > additional work of my own and work by Carlos Alberto Lopez Perez > <[email protected]> to port to kfreebsd-amd64. > > I have some concerns about affecting behavior on Linux, as not absolutely > everything is bracketed by #if defined(VGO_freebsd) and some of the changes > look slightly fishy, such as > - vg_assert(seg->end - seg->start >= phdrs[idx].p_filesz); > + vg_assert(seg->end - seg->start + 1 >= phdrs[idx].p_filesz); > but I want to get this patch out there in the hopes that it is beneficial to > others.
I'll have a look as soon as I have some free time. I was also thinking that the patch may be applied only in the kfreebsd builds, so it wouldn't interfere with the linux builds. What did you do to see if the build actually works? A simple stress-test for the MemCheck tool would be to run it on firefox/iceaweasel and libreoffice and see what happens. Also, does it work on kfreebsd-i386 too? Anyway, as I mentioned on the debian-bsd list the real problem here is not really the patch itself, but finding someone willing to maintain it in the future (at least until it gets merged upstream) since I'm not qualified (nor really interested) in the kfreebsd ports. So would you be willing to continue to maintain the patch in the future? If so you are welcome to push your changes to the collab-maint git repository where valgrind is maintained [0] in a separate branch called, say, "kfreebsd" (possibily without the d/changelog changes). Cheers [0] http://anonscm.debian.org/gitweb/?p=collab-maint/valgrind.git;a=summary -- perl -E '$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
signature.asc
Description: Digital signature
