Thanks.
smartboyhw (Howard Chan) 2013/3/4 Aditya Vaidya <kroq.ga...@gmail.com> > Hello, > > I'm kinda jumping in here, but I think "This is a" should be removed from > the package's short description. > > Sincerely, > kroq-gar78 > I will implement those for 1.0-5. Sorry since I'm a new guy for Debian > (not for Ubuntu). > > > 2013/3/3 Paul Wise <p...@debian.org> > >> On Sun, Mar 3, 2013 at 6:30 PM, Ho Wan Chan wrote: >> >> > More information about hello can be obtained from >> http://www.example.com. >> >> That doesn't make sense, your package is vmodsynth and that is not its >> website. >> > My fault for not changing the template:P > >> >> > I am looking for a sponsor for my package "vmodsynth" >> >> I don't intend to sponsor this package, but here is a review: >> >> If you contact upstream, please tell them about our upstream guide: >> >> http://wiki.debian.org/UpstreamGuide >> >> debian/source/include-binaries looks very wrong, debian/changelog >> should be the only location for the Debian changelog to be stored in >> the source package. >> > That's because I don't know how to fix > http://lintian.debian.org/tags/no-upstream-changelog.html > >> >> Here is a better watch file for this package: >> >> version=3 >> https://launchpad.net/vmodsynth/+download >> .*/vmodsynth-(\d[\d\.+)\.(?:zip|tgz|tbz|txz|(?:tar\.(?:gz|bz2|xz))) >> > Well I shall implement it, however Launchpad downloads are a headache:) > >> >> Please get the manual page included upstream. >> > > I would like to say that there is no manpage upstream. > >> >> None of the comments in debian/rules are needed, please remove them. >> > Forgotten to. > >> >> Please add --parallel to the arguments of dh in debian/rules. >> > OK > >> >> debian/README.source is not needed, it duplicates debian/rules, >> debian/control Build-Depends and the upstream README. >> >> No need to distribute the upstream README in the binary package, since >> it is mainly build instructions. Best just remove debian/docs >> altogether. >> > OK. > >> >> The Vcs-* fields are for the Debian packaging, not for upstream. >> > Sorry. > >> >> Does the package really need such a new gcc? >> > > We need to since that it is written in C++ 11 (for specific reasons, see > the .pdf), which is starting to get supported in gcc 4.7 > > >> >> You should never manually depend on libraries, always use the >> automatic depends created by ${shlibs:Depends} instead. >> > Oops sorry. > >> >> Please run wrap-and-sort -sa to wrap and sort various files. >> >> I would suggest using debhelper compat 9 and dh-autoreconf instead of >> autotools-dev. >> > OK. > >> >> Please read the devref section on debian/changelog best practices: >> >> >> http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-debian-changelog >> >> doc/vmodsynth_doc.pdf is a generated file, please ensure that it is >> regenerated at build time, you will need to build-depend on pdfTeX to >> do that. >> >> It would be a good idea to distribute doc/vmodsynth_doc.pdf in a >> binary package, either vmodsynth itself or vmodsynth-doc. >> > Thanks for your tip. > >> >> Automatic checks: >> >> https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package >> >> dpkg-shlibdeps: >> >> Lots of warnings, but thats a GTK+ bug. >> >> lintian (debian/compat 9 fixes the first two): >> >> W: vmodsynth: hardening-no-relro usr/bin/vmodsynth >> W: vmodsynth: hardening-no-fortify-functions usr/bin/vmodsynth >> P: vmodsynth: no-upstream-changelog >> >> OK I shall use ver. 9 then. For no-upstream-changelog I don't know how > to fix. > >> bfbtester: >> >> When I ran vmodsynth under bfbtester, I got hundreds of megabytes of >> core files due to segfaults. Please investigate and fix this issue. >> >> cppcheck (looks like the same issue as bfbtester): >> >> [src/main.cpp:40]: (error) Buffer overrun possible for long command >> line arguments. >> > Hmm let me see if I can contact upstream developer. > >> >> blhc (use debian/compat 9 to fix): >> >> CXXFLAGS missing >> CPPFLAGS missing >> LDFLAGS missing >> > Compat 9 then:) > >> >> similarity-tester: >> >> Seems to be quite a lot of code duplication going on: >> >> ./src/AlsaDriver.h consists for 75 % of >> ./src/AlsaDriver.cpp material >> ./src/modules/v702.cpp consists for 76 % of >> ./src/modules/v701.cpp material >> ./src/modules/v701.cpp consists for 77 % of >> ./src/modules/v702.cpp material >> ./src/ModuleList.h consists for 79 % of >> ./src/ModuleList.cpp material >> ./src/Inlet.h consists for 80 % of >> ./src/Outlet.h material >> ./src/Outlet.h consists for 81 % of ./src/Inlet.h >> material >> ./src/modules/v300.h consists for 84 % of >> ./src/modules/v203.h material >> ./src/modules/algorithms.h consists for 89 % of >> ./src/modules/v1005.h material >> ./src/modules/algorithms.cpp consists for 89 % of >> ./src/modules/v201.cpp material >> ./src/modules/v230.h consists for 90 % of >> ./src/modules/v203.h material >> ./src/modules/v703.h consists for 90 % of >> ./src/modules/v701.h material >> ./src/Outlet.cpp consists for 90 % of >> ./src/Inlet.cpp material >> ./src/Inlet.cpp consists for 91 % of >> ./src/Outlet.cpp material >> ./src/modules/v203.h consists for 91 % of >> ./src/modules/v230.h material >> ./src/modules/v100.h consists for 91 % of >> ./src/modules/v230.h material >> ./src/modules/v1005.h consists for 92 % of >> ./src/modules/v1001.h material >> ./src/modules/v101.h consists for 93 % of >> ./src/modules/v203.h material >> ./src/modules/v200.h consists for 95 % of >> ./src/modules/v210.h material >> ./debian/README.source consists for 95 % of ./README >> material >> ./src/modules/v1001.h consists for 95 % of >> ./src/modules/v201.h material >> ./src/modules/v701.h consists for 96 % of >> ./src/modules/v703.h material >> ./src/modules/v210.h consists for 97 % of >> ./src/modules/v201.h material >> ./src/modules/v400.h consists for 98 % of >> ./src/modules/v702.h material >> ./src/modules/v201.h consists for 98 % of >> ./src/modules/v702.h material >> ./src/modules/v702.h consists for 99 % of >> ./src/modules/v400.h material >> ./README consists for 100 % of >> ./debian/README.source material >> >> OK upstream developer contact then. > >> -- >> bye, >> pabs >> >> http://wiki.debian.org/PaulWise >> > > smartboyhw (Howard Chan) > Ubuntu member >
