Package: skytools3,skytools3-walmgr
Version: 3.1.3-1
Severity: important
User: [email protected]
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package left unowned files on
the system after purge, which is a violation of policy 6.8:

http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails

The leftover files are actually alternatives that were installed by the
package but have not been properly removed.

While there is ongoing discussion how to remove alternatives correctly
(see http://bugs.debian.org/71621 for details) the following strategy
should work for regular cases:
* 'postinst configure' always installs the alternative
* 'prerm remove' removes the alternative
* 'postrm remove' and 'postrm disappear' remove the alternative
In all other cases a maintainer script is invoked (e.g. upgrade,
deconfigure) the alternatives are not modified to preserve user
configuration.
Removing the alternative in 'prerm remove' avoids having a dangling link
once the actual file gets removed, but 'prerm remove' is not called in
all cases (e.g. unpacked but not configured packages or disappearing
packages) so the postrm must remove the alternative again
(update-alternatives gracefully handles removal of non-existing
alternatives).

Note that the arguments for adding and removing alternatives differ, for
removal it's 'update-alternatives --remove <name> <path>'.

Filing this as important as having a piuparts clean archive is a release
goal since lenny.

>From the attached log (scroll to the bottom...):

0m33.0s ERROR: WARN: Broken symlinks:
  /usr/share/man/man1/queue_splitter.1.gz -> /etc/alternatives/queue_splitter.1
  /usr/share/man/man1/queue_mover.1.gz -> /etc/alternatives/queue_mover.1
  /usr/share/man/man1/scriptmgr.1.gz -> /etc/alternatives/scriptmgr.1
  /usr/share/man/man1/londiste.1.gz -> /etc/alternatives/londiste.1
  /usr/bin/queue_splitter -> /etc/alternatives/queue_splitter
  /usr/bin/queue_mover -> /etc/alternatives/queue_mover
  /usr/bin/scriptmgr -> /etc/alternatives/scriptmgr
  /usr/bin/londiste -> /etc/alternatives/londiste
  /etc/alternatives/queue_splitter.1 -> /usr/share/man/man1/queue_splitter3.1.gz
  /etc/alternatives/queue_splitter -> /usr/bin/queue_splitter3
  /etc/alternatives/queue_mover.1 -> /usr/share/man/man1/queue_mover3.1.gz
  /etc/alternatives/queue_mover -> /usr/bin/queue_mover3
  /etc/alternatives/scriptmgr.1 -> /usr/share/man/man1/scriptmgr3.1.gz
  /etc/alternatives/scriptmgr -> /usr/bin/scriptmgr3
  /etc/alternatives/londiste.1 -> /usr/share/man/man1/londiste3.1.gz
  /etc/alternatives/londiste -> /usr/bin/londiste3

0m34.7s ERROR: FAIL: Package purging left files on system:
  /etc/alternatives/londiste -> /usr/bin/londiste3       not owned
  /etc/alternatives/londiste.1 -> /usr/share/man/man1/londiste3.1.gz     not 
owned
  /etc/alternatives/queue_mover -> /usr/bin/queue_mover3         not owned
  /etc/alternatives/queue_mover.1 -> /usr/share/man/man1/queue_mover3.1.gz      
 not owned
  /etc/alternatives/queue_splitter -> /usr/bin/queue_splitter3   not owned
  /etc/alternatives/queue_splitter.1 -> 
/usr/share/man/man1/queue_splitter3.1.gz         not owned
  /etc/alternatives/scriptmgr -> /usr/bin/scriptmgr3     not owned
  /etc/alternatives/scriptmgr.1 -> /usr/share/man/man1/scriptmgr3.1.gz   not 
owned
  /usr/bin/londiste -> /etc/alternatives/londiste        not owned
  /usr/bin/queue_mover -> /etc/alternatives/queue_mover  not owned
  /usr/bin/queue_splitter -> /etc/alternatives/queue_splitter    not owned
  /usr/bin/scriptmgr -> /etc/alternatives/scriptmgr      not owned
  /usr/share/man/man1/londiste.1.gz -> /etc/alternatives/londiste.1      not 
owned
  /usr/share/man/man1/queue_mover.1.gz -> /etc/alternatives/queue_mover.1       
 not owned
  /usr/share/man/man1/queue_splitter.1.gz -> /etc/alternatives/queue_splitter.1 
 not owned
  /usr/share/man/man1/scriptmgr.1.gz -> /etc/alternatives/scriptmgr.1    not 
owned
  /var/log/skytools/     not owned

0m46.4s ERROR: WARN: Broken symlinks:
  /usr/share/man/man1/walmgr.1.gz -> /etc/alternatives/walmgr.1
  /usr/bin/walmgr -> /etc/alternatives/walmgr
  /etc/alternatives/walmgr.1 -> /usr/share/man/man1/walmgr3.1.gz
  /etc/alternatives/walmgr -> /usr/bin/walmgr3

0m48.3s ERROR: FAIL: Package purging left files on system:
  /etc/alternatives/walmgr -> /usr/bin/walmgr3   not owned
  /etc/alternatives/walmgr.1 -> /usr/share/man/man1/walmgr3.1.gz         not 
owned
  /usr/bin/walmgr -> /etc/alternatives/walmgr    not owned
  /usr/share/man/man1/walmgr.1.gz -> /etc/alternatives/walmgr.1  not owned


Note that postrm purge should also get rid of /var/log/skytools/


cheers,

Andreas

Attachment: skytools3_3.1.3-1.log.gz
Description: GNU Zip compressed data

Reply via email to