Hi,
I browsed the source archives of latd because pkgsrc still has latd 1.18,
and found that all version between and including 1.25 and 1.30 have the
bug. I wonder if that information is useful to others...
Btw, why not change the sprintf to
snprintf(error, sizeof(error),
"llogin version %s does not match latd version " VERSION, cmdbuf);
instead of arbitrarily limiting cmdbuf to 900 characters, which might
be too long if somebody in the future shortened the buffer error or
passed in a much longer VERSION from the Makefile?
Do we want to avoid snprintf()?
Explicit
1024 - sizeof("llogin version does not match latd version " VERSION)
looks complicated, but makes the size requirement openly visible, and
should be optimizable by modern compilers.
Regards,
-is
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
