* Giulio Paci <[email protected]>, 2013-01-08, 23:27:
Does debian/patches/compilation_fixes really fix only "compilation on
Debian systems"?
I split this patch into several patches.
Thanks!
I completed the generic implementation, added an implementation based
on __builtin_clzl and implemented a selection mechanism in
configure.ac.
The priority is:
x86 implementation
__builtin_clzl implementation
generic implementation
Looks good to me. (Although I suspect that the assembly implementation
is a case of premature optimization. Meh...)
The ZFile implementation worries me... Do I read it correctly that
filenames are passed to shell without any escaping?
Nitpicking: in src/util/Logger.cpp:
printf("%.3f\t", (float)(clock() - _startTime) / CLOCKS_PER_SEC);
A typecast to double would make more sense, as the compiler will promote
the resulting floating point number to double anyway. (There are more
similar buglets in this and other files; please grep for
CLOCKS_PER_SEC.)
--
Jakub Wilk
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
