Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Please unblock package gnucash. The version currently in sid fixes RC bug #696282. The debdiff is attached. Cheers, -- .''`. Sébastien Villemot : :' : Debian Developer `. `' http://www.dynare.org/sebastien `- GPG Key: 4096R/381A7594
diff -Nru gnucash-2.4.10/debian/changelog gnucash-2.4.10/debian/changelog --- gnucash-2.4.10/debian/changelog 2012-06-27 20:40:29.000000000 +0200 +++ gnucash-2.4.10/debian/changelog 2013-01-03 20:19:41.000000000 +0100 @@ -1,3 +1,10 @@ +gnucash (1:2.4.10-6) unstable; urgency=low + + * handle-xml-parse-failure.patch: new patch, fixes potential data loss when + XML parsing fails (Closes: #696282) + + -- Sébastien Villemot <sebast...@debian.org> Thu, 03 Jan 2013 20:19:13 +0100 + gnucash (1:2.4.10-5) unstable; urgency=low * gnucash-tip.patch: new patch, fixes tip-of-the-day window with GCC 4.7 diff -Nru gnucash-2.4.10/debian/patches/handle-xml-parse-failure.patch gnucash-2.4.10/debian/patches/handle-xml-parse-failure.patch --- gnucash-2.4.10/debian/patches/handle-xml-parse-failure.patch 1970-01-01 01:00:00.000000000 +0100 +++ gnucash-2.4.10/debian/patches/handle-xml-parse-failure.patch 2012-12-25 23:03:30.000000000 +0100 @@ -0,0 +1,33 @@ +Description: Handle return value of xmlParseDocument() + Ignoring errors can lead to data loss. +Author: Sébastien Villemot <sebast...@debian.org> +Bug: https://bugzilla.gnome.org/show_bug.cgi?id=672364 +Bug-Debian: http://bugs.debian.org/696282 +Last-Update: 2012-12-25 +--- +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ +--- a/src/backend/xml/sixtp.c ++++ b/src/backend/xml/sixtp.c +@@ -695,6 +695,7 @@ + gpointer *parse_result) + { + sixtp_parser_context *ctxt; ++ int parse_ret; + + if (!(ctxt = sixtp_context_new(sixtp, global_data, data_for_top_level))) + { +@@ -706,12 +707,12 @@ + ctxt->data.saxParserCtxt->sax = &ctxt->handler; + ctxt->data.saxParserCtxt->userData = &ctxt->data; + ctxt->data.bad_xml_parser = sixtp_dom_parser_new(gnc_bad_xml_end_handler, NULL, NULL); +- xmlParseDocument( ctxt->data.saxParserCtxt ); ++ parse_ret = xmlParseDocument( ctxt->data.saxParserCtxt ); + //xmlSAXUserParseFile(&ctxt->handler, &ctxt->data, filename); + + sixtp_context_run_end_handler(ctxt); + +- if (ctxt->data.parsing_ok) ++ if (parse_ret == 0 && ctxt->data.parsing_ok) + { + if (parse_result) + *parse_result = ctxt->top_frame->frame_data; diff -Nru gnucash-2.4.10/debian/patches/series gnucash-2.4.10/debian/patches/series --- gnucash-2.4.10/debian/patches/series 2012-06-27 20:26:17.000000000 +0200 +++ gnucash-2.4.10/debian/patches/series 2012-12-19 21:30:18.000000000 +0100 @@ -5,3 +5,4 @@ taxi0-presentation_options.patch taxi1-customization_improvements.patch gnucash-tip.patch +handle-xml-parse-failure.patch
signature.asc
Description: Digital signature
