Package: lftp
Version: 4.3.8-1.1
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu raring ubuntu-patch



In Ubuntu, the attached patch was applied to achieve the following:

  * gets-undefined-in-C11.patch: Only play with gets() if it's defined.

This is needed because glibc 2.16 (found in Debian experimental and
Ubuntu raring) no longer defines gets(), as it's been dropped from
ISO C11.  The patch itself should be self-explanatory.

... Adam


-- System Information:
Debian Release: wheezy/sid
  APT prefers raring-updates
  APT policy: (500, 'raring-updates'), (500, 'raring-security'), (500, 'raring')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.7.0-7-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru lftp-4.3.8/debian/changelog lftp-4.3.8/debian/changelog
diff -Nru lftp-4.3.8/debian/patches/gets-undefined-in-C11.patch lftp-4.3.8/debian/patches/gets-undefined-in-C11.patch
--- lftp-4.3.8/debian/patches/gets-undefined-in-C11.patch	1969-12-31 17:00:00.000000000 -0700
+++ lftp-4.3.8/debian/patches/gets-undefined-in-C11.patch	2013-01-02 12:45:29.000000000 -0700
@@ -0,0 +1,19 @@
+Description: Only play with gets() if it's defined.
+Author: Adam Conrad <[email protected]>
+Forwarded: no
+
+--- lftp-4.3.8.orig/lib/stdio.in.h
++++ lftp-4.3.8/lib/stdio.in.h
+@@ -702,10 +702,12 @@ _GL_WARN_ON_USE (getline, "getline is un
+ /* It is very rare that the developer ever has full control of stdin,
+    so any use of gets warrants an unconditional warning; besides, C11
+    removed it.  */
++#ifdef gets
+ #undef gets
+ #if HAVE_RAW_DECL_GETS
+ _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
+ #endif
++#endif
+ 
+ 
+ #if @GNULIB_OBSTACK_PRINTF@ || @GNULIB_OBSTACK_PRINTF_POSIX@
diff -Nru lftp-4.3.8/debian/patches/series lftp-4.3.8/debian/patches/series
--- lftp-4.3.8/debian/patches/series	2012-12-01 08:09:43.000000000 -0700
+++ lftp-4.3.8/debian/patches/series	2013-01-02 12:45:01.000000000 -0700
@@ -1,2 +1,3 @@
 config-dns-inet6_before_inet.patch
 lftp_sys-stdint-kfreebsd.patch
+gets-undefined-in-C11.patch

Reply via email to