On Fri, 28 Dec 2012, Martin Quinson wrote:
> -             if [ -e "$QUILT_PC/$patch" ]
> +             if ! [ -e "$QUILT_PC/$patch" ]
>               then
> -                     touch $QUILT_PC/$patch/.timestamp
> -             else
>                       mkdir "$QUILT_PC/$patch"
>               fi
> +             touch "$QUILT_PC/$patch/.timestamp"

Right, I forgot that we always want to update the timestamp...

> +             files_in_patch "$patch" |
> +             grep -v '^$' |
> +             while read file
> +             do
> +                     touch -r "$QUILT_PC/$patch/.timestamp" "$file"
> +             done

I was more thinking about using “… | xargs -d '\n' touch -r
"$QUILT_PC/$patch/.timestamp"” for this task. It should call it
once only except when too many files are listed and when the list
must be split.

> -             elif [ -z "$(shopt -s nullglob ; echo "$QUILT_PC/$patch/"*)" ]
> +             elif [ "$(shopt -s nullglob ; echo "$QUILT_PC/$patch/"*)" == 
> "$QUILT_PC/$patch/.timestamp" ]

This is a pre-existing bug, right? It should probably go in a different
commit when submitted upstream.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/


--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to