On 11:18 Thu 15 Nov , Jakub Wilk wrote: > * Vasudev Kamath <[email protected]>, 2012-11-13, 20:13: > >>What did this line do, and why it was removed? > >> find . -name config.mk | xargs sed -i 's,-s ${LIBS},${LIBS},' > >Not sure why it was removed, it was not present when I took over > >source from Micahel. After reading man page for *ld* I see that > >this option is used to strip of debugging symbols of the binaries. > >By removing these tools will contain the debugging symbols so I'm > >not sure how to fix this? The policy 10.1 says symbols should be > >stripped off with -s to install also section 4.9.1 says about > >nostrip option does this mean by default debhelper strips of > >symbols? > > Yes, dh_strip strips symbols by default (if > DEB_BUILD_OPTIONS=nostrip is not set). > > Using -s unconditionally is a bad idea, because then symbols are > getting stripped even with nostrip. > > Of course modifying upstream files in-place in debian/rules is > probably a bad idea. (If you wanted do that, you'd have to restore > the original ones in the clean target.)
So I guess its okay that is dropped but I guess needs to be recorded in
changelog? But I don't know how to phrase this removal though :-/
>
> Also note that this is slightly broken: ${LIBS} is expanded by make
> to an empty string, so you actually end up calling:
>
> find . -name config.mk | xargs sed -i 's,-s ,,'
True :-)
--
Vasudev Kamath
http://copyninja.info
Connect on ~friendica: copyninja@{frndk.de | vasudev.homelinux.net}
IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net}
GPG Key: C517 C25D E408 759D 98A4 C96B 6C8F 74AE 8770 0B7E
signature.asc
Description: Digital signature
