Le mardi 23 octobre 2012 à 21:31 +0200, Michael Biebl a écrit :

> Looking at the resulting dependencies, I noticed that network.target is
> both in After and Before. That won't work obviously.
> 
> Which makes me think, why the original patch for openSUSE uses the
> Before ordering in
> r = unit_add_two_dependencies_by_name(u, UNIT_BEFORE, e, dep, NULL, true);
> 
> Shouldn't that rather be UNIT_AFTER?
> 
> Frederic, maybe you can shed some light on this.

First, make sure you have this patch
(https://build.opensuse.org/package/view_file?file=0001-service-Fix-dependencies-added-when-parsing-insserv..patch&package=systemd&project=Base%3ASystem&rev=df941bd8d87aadf2194e1eb4ada5c1d9
) in your tree.

I thought openSUSE was the only one using the insserv code in systemd
and since upstream was more in a "kill any distro specific code" mood
when I wrote this patch, I never pushed it upstream (but I still can ;)

Without this patch, the dependencies between target were incorrectly
set, as you figured (you'll note now UNIT_BEFORE is set with an
by_name_inverse call).

-- 
Frederic Crozat <[email protected]>
SUSE


--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to