Bug#689569: Unchecked implicit conversion from float to enum

[Michael Tautschnig]

Package: openarena
Version:

While building the package using our research compiler infrastructure we noticed
the following unchecked implicit conversion with possibly undefined behaviour:

Lines 401-403 of code/q3_ui/ui_playermodel.c:

        qboolean precache;

        precache = trap_Cvar_VariableValue("com_buildscript");

The conversion of an arbitrary float value to an enum (qboolean) isn't
well-defined.

Likely the best fix is to change the right-hand side to a comparison to
non-zero:

        precache = trap_Cvar_VariableValue("com_buildscript") != 0;

Best,
Michael

pgp4HzxXuc0l0.pgp
Description: PGP signature