On Sep 18, 2012, at 07:37 PM, Dmitry Shachnev wrote:

>On Tue, 18/09/2012 11:05 -0400, Barry Warsaw wrote:
>> So I guess if no one else has any other suggestions, then the following
>> changes should be made to the patch, after which it could be applied:
>> 
>> * compare against site.getsitepackages() for directories that should not be
>>   removed.
>> * update the docstring to indicate that site package directories are not
>>   removed even if magic_tag is None
>
>Done, the updated patch attached. Thanks for the suggestions!
>
>Also, I've updated my branch at lp:~mitya57/+junk/python3-defaults so
>that it can be easily merged.

Thanks for making the changes.  Note that the above branch has some other
changes which aren't related to this bug.  I'm disinclined to include those
fixes here for that reason, and also because i think there are better ways to
do it, e.g. by using a context manager to handle the automatic closing of the
files, instead of relying on potentially buggy explicit .closes()

Attachment: signature.asc
Description: PGP signature

Reply via email to