Am Donnerstag, den 13.09.2012, 00:08 +0200 schrieb Francesco Poli: > Control: tags 687452 + patch > > > On Wed, 12 Sep 2012 22:53:20 +0200 Benjamin Drung wrote: > > > Am Mittwoch, den 12.09.2012, 22:43 +0200 schrieb Francesco Poli > > (wintermute): > > > I hope that fixing this issue is not too hard and may be done soon > > > (through an upload to experimental, since I don't expect behavioral > > > changes > > > in unstable or testing during a freeze...). > > > > Hello Benjamin, > thanks a lot for your fast reply! :-)
I will try to not let it happen again. ;) > > Patches are welcome otherwise I can't promise that this bug will be > > fixed. > > OK, this is my attempt to fix the bug. > > I tested a modified licensecheck on the minimal test case that I > provided and on a directory tree containing about 11400 files to scan. > It seems that It Works For Me™. > > So maybe I have a patch... > I wish the BTS supported the "maybe-patch" tag! ;-) > > Take into account that my Perl knowledge is just a smattering > and it is rusty, too... My Perl foo isn't that good either. Why did you move the Fortran comment removal line up to the top of the block? > So please, test my patch accurately. It passes all licensecheck tests (in test/test_licensecheck). There aren't that many test for licensecheck, but the test suite will grow with every bug report. I adapted your test case for the test suite (file attached). > Legal details: I hereby release my patch under the same licensing terms > as licensecheck (that is to say, under the GNU GPL version 2 or later). > > > > > I assume (depends on the actual change) that the fix can go into > > unstable and migrate to testing. Our git repository has currently some > > bug fixes that I want to get into testing. > > This is something you will have to discuss with the release team: > I have no experience of such discussions, so I won't try to predict the > outcome... > > > Thanks for your time and responsiveness! > Bye. -- Benjamin Drung Debian & Ubuntu Developer
c Copyright (c) 2012, Devscripts developers c c Redistribution and use in source and binary forms, with or without c modification, are permitted provided that the following conditions are c met: c c - Redistributions of source code must retain the above copyright c notice, this list of conditions and the following disclaimer. c c - Redistributions in binary form must reproduce the above copyright c notice, this list of conditions and the following disclaimer in the c documentation and/or other materials provided with the c distribution. c c THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS c IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED c TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A c PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT c HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, c SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT c LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, c DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY c THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT c (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE c OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
signature.asc
Description: This is a digitally signed message part
