Package: enca
Version: 1.14-1
Severity: normal
Tags: patch

Dear Maintainer,

The CFLAGS hardening/build flags are missing because they are
overwritten in debian/rules. For more hardening information
please have a look at [1], [2] and [3].

The following patch fixes the issue.

diff -Nru enca-1.14/debian/rules enca-1.14/debian/rules
--- enca-1.14/debian/rules      2012-09-11 11:46:23.000000000 +0200
+++ enca-1.14/debian/rules      2012-09-11 20:33:01.000000000 +0200
@@ -13,7 +13,7 @@
 DEB_BUILD_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
 
 
-CFLAGS = -Wall -g
+CFLAGS += -Wall -g
 
 ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
        CFLAGS += -O0

To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package and check
the build log with `blhc` (hardening-check doesn't catch
everything):

    $ hardening-check /usr/lib/libenca.so.0.5.1 
/usr/lib/debug/usr/lib/libenca.so.0.5.1 /usr/bin/enca
    /usr/lib/libenca.so.0.5.1:
     Position Independent Executable: no, regular shared library (ignored)
     Stack protected: yes
     Fortify Source functions: no, only unprotected functions found!
     Read-only relocations: yes
     Immediate binding: no not found!
    /usr/lib/debug/usr/lib/libenca.so.0.5.1:
     Position Independent Executable: no, regular shared library (ignored)
     Stack protected: yes
     Fortify Source functions: unknown, not linked against libc
     Read-only relocations: yes
     Immediate binding: no not found!
    /usr/bin/enca:
     Position Independent Executable: no, normal executable!
     Stack protected: no, not found!
     Fortify Source functions: yes (some protected functions found)
     Read-only relocations: yes
     Immediate binding: no not found!

(Position Independent Executable and Immediate binding is not
enabled by default.)

Use find -type f \( -executable -o -name \*.so\* \) -exec
hardening-check {} + on the build result to check all files.

Regards,
Simon

[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

Attachment: signature.asc
Description: Digital signature

Reply via email to