Package: freeradius-dialupadmin
Version: 1.0.2-4
Severity: normal

Creating group without user(s) in it fails. I don't remember if a row in SQL is 
added or not, but these to diffs fixes it:


--- usr/share/freeradius-dialupadmin/lib/sql/create_group.php3  2004-04-18 
16:28:14.000000000 +0200
+++ /usr/share/freeradius-dialupadmin/lib/sql/create_group.php3 2005-05-30 
23:46:48.296958096 +0200
@@ -27,6 +27,10 @@
                        }
                }
        }
+        elseif (empty($Members))
+                $res = @da_sql_query($link,$config,
+                "INSERT INTO $config[sql_usergroup_table] (groupname)
+                VALUES ('$login');");
        if (!$da_abort){
                foreach($show_attrs as $key => $attr){
                        if ($attrmap["$key"] == 'none')


--- show_groups.php3    2003-12-15 17:55:29.000000000 +0100
+++ /usr/share/freeradius-dialupadmin/htdocs/show_groups.php3   2005-04-26 
23:26:54.394521512 +0200
@@ -58,13 +58,15 @@
 $link = @da_sql_pconnect($config);
 if ($link){
        $search = @da_sql_query($link,$config,
-       "SELECT COUNT(*) as counter,groupname FROM $config[sql_usergroup_table] 
GROUP BY groupname;");
+       "SELECT COUNT(*) as counter,groupname,username FROM 
$config[sql_usergroup_table] GROUP BY groupname;");
        if ($search){
                if (@da_sql_num_rows($search,$config)){
                        while( $row = @da_sql_fetch_array($search,$config) ){
                                $num++;
                                $group = $row[groupname];
                                $num_members = $row[counter];
+                               /* Decrease $num_members if the username == 
NULL. */
+                               if ($row[username] == "") $num_members --;
                                echo <<<EOM
                <tr align=center>
                        <td>$num</td>


-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.6.8-2-386
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages freeradius-dialupadmin depends on:
ii  apache [httpd]            1.3.33-6sarge1 versatile, high-performance HTTP s
ii  apache-ssl [httpd]        1.3.33-6sarge1 versatile, high-performance HTTP s
ii  php4                      4:4.3.10-16    server-side, HTML-embedded scripti

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to