On 16/07/2012 17:24, Jakub Wilk wrote:
> The current version appears to be at:
> http://mentors.debian.net/debian/pool/main/p/peg/peg_0.1.9-1.dsc
I updated it.
In addition to your recommendations I also changed section from "misc"
to "devel".
> Lintian says:
> P: peg source: package-lacks-versioned-build-depends-on-debhelper 7
> W: peg: hardening-no-relro usr/bin/leg
> W: peg: hardening-no-relro usr/bin/peg
Fixed.
> The examples directory could act as a test suite. Please run it at build
> time.
Done.
> In my opinion, the long description is a bit too… long. I would remove
> at least the citation, maybe something more, but I'm not sure what. You
> might want to ask debian-l10n-english@ for an advice.
I removed most of the description, using *yacc packages as reference. It
seems more readable now.
> Please merge changelog entries for 0.1.7-1, 0.1.8-1 and 0.1.9-1 into one.
Done.
> It would be probably better not to compress examples. Compression makes
> playing with them a bit harder, whereas the space savings are minute.
The package leaves examples uncompressed now.
> Upstream makefile strips the binaries unconditionally. However, for
> Debian, binaries should be not stripped if the package was built with
> DEB_BUILD_OPTIONS=nostrip.
Fixed.
> Please forward manpage_fixes.patch upstream.
I already forwarded it a long time ago. I just did not update a new
version of the package on mentors.
> I always feel uneasy about “Forwarded: not-needed” patches. I believe
> parts of makefile_configuration.patch could be forwarded upstream, and
> the rest of the logic could be moved to debian/rules
In this case "Forwarded: not-needed" means that upstream changed its
building scheme completely internally, so there is no point in
forwarding this patch that cannot apply to anything.
>> all : peg leg
>> + cp -a peg.1 leg.1
>
> Wouldn't it be better to make leg manpage a symlink to peg one, instead
> of shipping two identical files? You could ask upstream to include the
> symlink directly in their tarball.
Installed as symlink now.
>> -PREFIX = /usr/local
>> +PREFIX = /usr
>
> Could be overridden in debian/rules.
As far as I know I should either move the binaries by hand or patch the
Makefile so that ?= is used in place of =. Is there any other solution?
>> %.peg-c : %.peg compile.c
>> - ./peg -o $@ $<
>> + #./peg -o $@ $<
>>
>> leg.o : leg.c
>>
>> leg.c : leg.leg compile.c
>> - ./leg -o $@ $<
>> + #./leg -o $@ $<
>
> Hmm, why?
Because otherwise the compilation fails if the directory is clean, but
compile.c or .leg/.peg files have a more recent timestamp than the
target. These instructions are only useful when developing peg and leg
and are safe to skip.
Bests,
Giulio.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
