> Subject: Bug#674179: scantool is unusable with eml327 clones
> From: xantare...@hotmail.com
> To: sub...@bugs.debian.org
> Date: Wed, 23 May 2012 17:48:29 +0200
>
> Package: scantool
> Version: 1.21+dfsg-2
> Severity: important
>
> Hi,
>
> Currently scantool cannot be used by all eml327 devices, the gui closes with
> the eml327 clones.
> The current debian patch 'allow-eml327-clones.patch' is incorrect.
> The return code is changed in Reset_handle_clone function.
> As a fix, just setting is_not_genuine_scan_tool=FALSE makes it usable.
>
> Regards.
>
>
>
>
> -- System Information:
> Debian Release: wheezy/sid
> APT prefers precise-updates
> APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500,
> 'precise'), (100, 'precise-backports')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 3.2.0-24-generic (SMP w/2 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
>
> Versions of packages scantool depends on:
> ii libc6 2.15-0ubuntu10
> ii libx11-6 2:1.4.99.1-0ubuntu2
> ii libxcursor1 1:1.1.12-1
> ii libxext6 2:1.3.0-3build1
> ii libxpm4 1:3.5.9-4
> ii libxxf86vm1 1:1.1.1-2build1
>
> scantool recommends no packages.
>
> scantool suggests no packages.
>
> -- no debconf information
Hi,
Here's more : I attached a new patch that fixes the problem by just setting
is_not_genuine_scan_tool=FALSE, changing the return state code is useless.
I successfully tested this on a cheap elm327.
Looking forward to get this to work out of the box in debian.
Regards.
diff -ru scantool-1.21+dfsg.orig/reset.c scantool-1.21+dfsg/reset.c
--- scantool-1.21+dfsg.orig/reset.c 2012-05-28 10:55:44.098842129 +0200
+++ scantool-1.21+dfsg/reset.c 2012-05-28 10:57:07.275254596 +0200
@@ -282,11 +282,8 @@
int Reset_handle_clone()
{
- alert("Your device does not appear to be a genuine ElmScan 5. Due to their poor",
- "quality and high support costs, ELM327 clones are no longer supported.",
- "Please visit www.ScanTool.net to purchase a genuine scan tool.", "OK", NULL, 0, 0);
-
- is_not_genuine_scan_tool = TRUE;
+
+ is_not_genuine_scan_tool = FALSE;
return RESET_CLOSE_DIALOG;
