Guido Günther <[email protected]> writes:

[...]

> Looks great! Can you document commit1 and commit2 via epydoc too and add
> a testcase to tests/test_GitRepository.py that tests the success as well
> as the failure case? 

Ok, I'll do that.

> As a bonus construct the args argument via args = GitArgs(commit1,
> commit2)
>
> for consistency with other recent code. I'd be happy to apply it then.

I did it in my first implementation, but Repository._git_inout() does
not like it :-/

Regards.

-- 
Daniel Dehennin
Récupérer ma clef GPG:
gpg --keyserver pgp.mit.edu --recv-keys 0x7A6FE2DF

Attachment: pgpwS5yzYH9vn.pgp
Description: PGP signature

Reply via email to