tag 664950 patch pending
thanks

Lucas Nussbaum <[email protected]> (21/03/2012):
> During a rebuild of all packages in sid, your package failed to build on
> amd64.
> 
> Relevant part:
> > /usr/bin/ld: ../libxdgutils/libxdgutils.a(XDGDesktopEntry.o): relocation 
> > R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared 
> > object; recompile with -fPIC
> > ../libxdgutils/libxdgutils.a: could not read symbols: Bad value
> > collect2: ld returned 1 exit status

Hi,

please find attached the source debdiff for my NMU, just uploaded to
unstable. Setting -fPIC for the whole build would also work, but looking
at Debian Policy 10.2, it's only relevant for libraries, so I limited
that to the convenience library used during the build.

Mraw,
KiBi.
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+goplay (0.5-1.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Build the convenience library with -fPIC, avoiding issues with
+    relocations (Closes: #664950):
+    + use--fPIC-for-the-convenience-library.diff
+  * Set urgency to “high” for the RC bug fix, needed for the apt
+    transition.
+
+ -- Cyril Brulebois <[email protected]>  Tue, 08 May 2012 01:44:14 +0200
+
 goplay (0.5-1) unstable; urgency=low
 
   * Acknowledge NMU (Closes: #659534).
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -0,0 +1 @@
+use--fPIC-for-the-convenience-library.diff
--- a/debian/patches/use--fPIC-for-the-convenience-library.diff
+++ b/debian/patches/use--fPIC-for-the-convenience-library.diff
@@ -0,0 +1,22 @@
+Description: Use -fPIC to build the convenience library.
+Author: Cyril Brulebois <[email protected]>
+Bug-Debian: http://bugs.debian.org/664950
+--- a/libxdgutils/Makefile.in
++++ b/libxdgutils/Makefile.in
+@@ -237,7 +237,7 @@ libxdgutils_a_SOURCES = \
+ 	XDGUtils.h \
+ 	XDGUtils.cpp
+ 
+-INCLUDES = -I.. $(LIBEPT_CFLAGS) -Wall -Werror -ggdb
++INCLUDES = -I.. $(LIBEPT_CFLAGS) -Wall -Werror -ggdb -fPIC
+ all: all-am
+ 
+ .SUFFIXES:
+--- a/libxdgutils/Makefile.am
++++ b/libxdgutils/Makefile.am
+@@ -32,4 +32,4 @@ libxdgutils_a_SOURCES = \
+ 	XDGUtils.h \
+ 	XDGUtils.cpp
+ 
+-INCLUDES = -I.. $(LIBEPT_CFLAGS) -Wall -Werror -ggdb
++INCLUDES = -I.. $(LIBEPT_CFLAGS) -Wall -Werror -ggdb -fPIC

Attachment: signature.asc
Description: Digital signature

Reply via email to