* Carsten Hey [2012-04-26 10:36 +0200]:
> Whilst checking gtkorphan I noticed that it uses a colon to separate
> package names in the code that seems to be supposed to remove orphaned
> packages from deborphans --show-deps output.  Back then when you wrote
> gtkorphan, a colon was a good choice as separator, but nowadays it is
> used to separate package names from the architecture, which can lead to
> undesirable results of such algorithms.
>
> The colon using code in gtkorphan_ops.pm is:
>
>     my $orphaned = join(":",@orphaned);
>     $orphaned=$orphaned.":";
>
> I think it should use for example "#" instead of ":".

I still think using a colon as separator is not that robust nowadays and
changing this might make gtkorphan more robust, regardless of what
I write below.


> Because the above is kind of fishy nowadays, I checked if the orphaned
> packages from deborphans --show-deps output are removed as seems to be
> intended.  They are not removed, neither when used with a deborphan that
> prints arch suffixes, nor when used with one that does not print arch
> suffixes.

Since deborphan does not print orphaned packages if -d is used, I assume
the code does the opposite of what I thought at first sight.  So this
part of the bug report seems to be invalid, although I think listing
orphaned packages in a tab "non-orphaned packages" is not what most
users would expect.

Please consider closing this bug if listing orphaned packages in the
list of non-orphaned packages is really intended.


Carsten



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to