severity 135299 important
merge 135299 115109
tags 135299 + patch
thanks
Pawel Wiecek write:
> On Oct 1, 10:45pm, Roger Leigh wrote:
> > Has any progress been made with this bug?
> I have some conceptions, but still need to check a few things before
> implementing them.
Attached is a patch to do this. It
1) If the device name starts with "/dev/", it strips off "/dev" rather
than all directories.
2) When creating the lock name, it replaces any '/'s with '.'s. Thus
/dev/pts/2 would become /pts/2, which would be written as
/var/lock/LCK...pts/2 which would be transformed to
/var/lock/LCK...pts.2
This isn't perfect; the locking could be abused if devices have '.'s
in their names (e.g. /dev/pts.2), but this is not very likely, and
since we can't have '/'s in lock names, I can't think of a better
solution. This is also safe in the face of UTF-8 device names.
This should solve the DevFS/devpts/udev/LVM issues with lockdev.
BTW, one issue I have is that in the source, we have
# define DEV_PATH "/dev"
yet when I print it out:
_debug( 3, "_dl_check_devname(%s) strip name = %s\n", devname,
DEV_PATH);
if (strncmp(DEV_PATH, p, strlen(DEV_PATH)) == 0) {
p += 4;
_debug( 3, "_dl_check_devname(%s) stripped name = %s\n",
devname, p);
} else {
it's "/dev/". However, I can't find out how the trailing "/" is
added. This is a little worrisome. It's not in the source, Makefile
or any other file, using grep to search.
Regards,
Roger
--
Roger Leigh
Printing on GNU/Linux? http://gimp-print.sourceforge.net/
Debian GNU/Linux http://www.debian.org/
GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
