tags 669140 +patch thanks On Tue, Apr 17, 2012 at 07:05:42PM +0100, Martin Michlmayr wrote: >Package: abcde >Version: 2.5.0-1 >Tags: patch > >I don't think it makes sense to submit data to the CDDB server when >obtaining it via musicbrainz. > >--- a/abcde (revision 292) >+++ b/abcde (working copy) >@@ -2697,7 +2720,7 @@ > echo "variousartists=$VARIOUSARTISTS" >> "$ABCDETEMPDIR/status" > echo "variousartiststyle=$VARIOUSARTISTSTYLE" >> "$ABCDETEMPDIR/status" > >- if [ "$EDITCDDB" = "y" ] && [ >"$UNINTENTIONALLY_ANGER_THE_FREEDB_PEOPLE" = "y" ]; then >+ if [ "$EDITCDDB" = "y" ] && [ "$CDDBMETHOD" = "cddb" ] && [ >"$UNINTENTIONALLY_ANGER_THE_FREEDB_PEOPLE" = "y" ]; then > if [ "$CDDBDATAMD5SUM" != "" ] && [ "$CDDBDATAMD5SUM" != > "$($MD5SUM "$CDDBDATA" | cut -d " " -f 1)" ]; then > # This works but does not have the necessary error > checking > # yet. If you are familiar with the CDDB spec
Agreed. Committed upstream. -- Steve McIntyre, Cambridge, UK. [email protected] Getting a SCSI chain working is perfectly simple if you remember that there must be exactly three terminations: one on one end of the cable, one on the far end, and the goat, terminated over the SCSI chain with a silver-handled knife whilst burning *black* candles. --- Anthony DeBoer -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
