Raphaël Hertzog dixit:
>The code in question seems legitimate:
Actually, it is a good example for a class method, hence static.
>class WP_Feed_Cache extends SimplePie_Cache {
> /**
> * Create a new SimplePie_Cache object
> *
> * @static
> * @access public
> */
I’d rather insert a “static” here. I believe it was only not done
due to the simplepie bug, considering the @static annotation comment
above.
> function create($location, $filename, $extension) {
> return new WP_Feed_Cache_Transient($location, $filename,
> $extension);
> }
>}
>I would thus kindly ask you to revert that change at least partially
>for all the methods that have been marked static and let upstream deal
>properly with the fallout of the incompatible change...
I think we should contact both upstreams about this, maybe they
will accept a coordinated change.
bye,
//mirabilos
--
“Having a smoking section in a restaurant is like having
a peeing section in a swimming pool.”
-- Edward Burr
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
