Package: xchat
Version: 2.4.1-0.1
Severity: important
Tags: patch

When building xchat on IA64 you get the following warning.

gtkutil.c: In function `gtkutil_file_req':
gtkutil.c:266: warning: implicit declaration of function `get_xdir_fs'
gtkutil.c:266: warning: cast to pointer from integer of different size

Because get_dir_fs() isn't defined, it is assumed to have a return
type of int.  Unfortunatley it's really a char * so the top bits get
chopped off.

The following patch includes the appropriate header file and cleans up
the source code to be inline and remove an unncessary cast.

Thanks,

-i
[EMAIL PROTECTED]
http://www.gelato.unsw.edu.au

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: ia64
Kernel: Linux 2.6.10
Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)

Versions of packages xchat depends on:
ii  libatk1.0-0              1.8.0-4         The ATK accessibility toolkit
ii  libc6.1                  2.3.2.ds1-20    GNU C Library: Shared libraries an
ii  libglib2.0-0             2.6.1-3         The GLib library of C routines
ii  libgtk2.0-0              2.4.14-2        The GTK+ graphical user interface 
ii  libpango1.0-0            1.6.0-3         Layout and rendering of internatio
ii  libperl5.8               5.8.4-6         Shared Perl library
ii  libssl0.9.7              0.9.7e-3        SSL shared libraries
ii  libx11-6                 4.3.0.dfsg.1-10 X Window System protocol client li
ii  python2.3                2.3.4-18        An interactive high-level object-o
ii  tcl8.4                   8.4.9-1         Tcl (the Tool Command Language) v8
ii  xchat-common             2.4.1-0.1       Common files for X-Chat
ii  xlibs                    4.3.0.dfsg.1-10 X Keyboard Extension (XKB) configu

-- no debconf information
--- xchat-2.4.1/src/fe-gtk/gtkutil.c	2004-08-11 13:45:45.000000000 +1000
+++ xchat-2.4.1-fixed/src/fe-gtk/gtkutil.c	2005-02-04 13:08:06.095886657 +1100
@@ -25,6 +25,7 @@
 #include <unistd.h>
 #include <fcntl.h>
 #include "fe-gtk.h"
+#include "../common/cfgfiles.h"
 
 #include <gtk/gtkbutton.h>
 #include <gtk/gtkclist.h>
@@ -262,8 +263,7 @@
 	if (last_dir[0])
 		gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (dialog), last_dir);
 	if (flags & FRF_ADDFOLDER)
-		gtk_file_chooser_add_shortcut_folder (GTK_FILE_CHOOSER (dialog),
-														  (char *)get_xdir_fs (), NULL);
+		gtk_file_chooser_add_shortcut_folder (GTK_FILE_CHOOSER (dialog), get_xdir_fs (), NULL);
 
 	freq = malloc (sizeof (struct file_req));
 	freq->dialog = dialog;

Reply via email to