On 17-03-12 20:15, [email protected] wrote: > Paul, as we spoke before, here is the proposed NMU patch.
For potential sponsors: in general I find it OK when somebody makes an NMU to nedit. I am just starting the NM process, but for now I can not upload these changes myself. Therefore I request Jari to find his own sponsor. > Let me know if there is anything that needs adjusting or if it is ok > to upload with these changes. Comments in-line below: basically: - extend changelog - (don't) change patch meta information > --- a/debian/changelog > +++ b/debian/changelog > @@ -1,3 +1,11 @@ > +nedit (1:5.6~cvs20081118-7.1) unstable; urgency=low > + > + * Non-maintainer upload. > + * Remove deprecated dpatch and upgrade to packaging format "3.0 quilt". > + * Update to Standards-Version to 3.9.3 and debhelper to 9. Did you need to make changes to update the Standards-Version? Did you check that the package is really according to the latest policy? Please document that in the changelog even if you didn't need to make changes (usually people write something like: "Update standards-version to 3.9.3 (no changes needed)"). However, I think we should follow: """ 11.4, 11.8.3, 11.8.4 Packages providing alternatives for `editor', `pager', `x-terminal-emulator', or `x-window-manager' should also provide a slave alternative for the corresponding manual page. """ Why do you update the debhelper to that level? Do you use any of it's features? I guess not :). Have you checked that updating the debhelper level doesn't change the build? For back-port reasons you don't want to update needlessly, but if I recall correctly level 5 is not recommended anymore, but maybe e.g. level 8 is more appropriate. So at least document in the changelog why you update it. > --- a/debian/patches/10_EOF_Parser_error.dpatch > +++ b/debian/patches/10_EOF_Parser_error.patch > @@ -1,9 +1,6 @@ > -#! /bin/sh /usr/share/dpatch/dpatch-run > -# Description: fix source/tags.c to properly parse EOF > -# Origin: upstream, > http://nedit.cvs.sourceforge.net/viewvc/nedit/nedit/source/tags.c?r1=1.70&r2=1.71 > -# Bug: > https://sourceforge.net/tracker/index.php?func=detail&aid=2687525&group_id=11005&atid=111005 > +From: Paul Gevers <[email protected]> > +Subject: Fix for SF bug #2687525: tipsfile parser error wrt to eof I suggest not to remove the original tags (in all the patches), as they document more than you do in your changes. They are already in DEP3 format if you remove the hash. Furthermore, I am not the author of this patch. > --- a/debian/patches/30_off_by_one.dpatch > +++ b/debian/patches/30_off_by_one.patch > @@ -1,11 +1,6 @@ > -#! /bin/sh /usr/share/dpatch/dpatch-run > -# Description: Fix for off-by-one error, potentially causing a crash > -# Origin: upstream, > http://nedit.cvs.sourceforge.net/viewvc/nedit/nedit/source/regularExp.c?r1=1.33&r2=1.34&view=patch > -# Author: Evan Teran > -# Bug: > https://sourceforge.net/tracker/index.php?func=detail&aid=2858723&group_id=11005&atid=111005 > +From: Paul Gevers <[email protected]> > +Subject: Fix off-by-one error, potentially causing a crash '(SF #2858723) Again, but more clear, you changed the authorship of this patch, which is not-done in the open-source world. (Also in 40_Pointer_to_Integer.patch). Paul
signature.asc
Description: OpenPGP digital signature
