Package: vlan
Version: 1.8-1

1. (significant)
   The ifdown script does not handle interfaces named vlan### or vlan0###
   due to the exit in the *) case. Although this is already a topic in
   bug report #196890, it is not fully fixed in 1.8-1.

2. (negligible)
   I prefer not to have any output of the ifup/ifdown scripts except it
   fails. In the case someone really wants the output it should depend on
   VERBOSITY variable.

Patch below.

Heiko

--- if-post-down.d/vlan.org     2004-08-19 11:12:22.000000000 +0200
+++ if-post-down.d/vlan 2005-01-28 15:09:50.000000000 +0100
@@ -5,6 +5,7 @@
 # to just probe for the right device name in /proc/net/vlan
 
 case "$IFACE" in
+       vlan*)  ;;
        eth*.0*)
                IF_VLAN_RAW_DEVICE=`echo $IFACE|sed 
"s/\(eth[0-9][0-9]*\)\..*/\1/"`
                ;;
@@ -24,4 +25,4 @@
   exit 0
 fi
 
-vconfig rem $IFACE
+vconfig rem $IFACE > /dev/null

--- if-pre-up.d/vlan.org        2004-08-19 11:12:22.000000000 +0200
+++ if-pre-up.d/vlan    2005-01-28 15:10:01.000000000 +0100
@@ -4,20 +4,20 @@
 
 case "$IFACE" in
        vlan0*)
-               vconfig set_name_type VLAN_PLUS_VID
+               vconfig set_name_type VLAN_PLUS_VID > /dev/null
                VLANID=`echo $IFACE|sed "s/vlan0*//"`
                ;;
        vlan*)
-               vconfig set_name_type VLAN_PLUS_VID_NO_PAD
+               vconfig set_name_type VLAN_PLUS_VID_NO_PAD > /dev/null
                VLANID=`echo $IFACE|sed "s/vlan0*//"`
                ;;
        eth*.0*)
-               vconfig set_name_type DEV_PLUS_VID
+               vconfig set_name_type DEV_PLUS_VID > /dev/null
                VLANID=`echo $IFACE|sed "s/eth[0-9][0-9]*\.0*//g"`
                IF_VLAN_RAW_DEVICE=`echo $IFACE|sed 
"s/\(eth[0-9][0-9]*\)\..*/\1/"`
                ;;
        eth*.*)
-               vconfig set_name_type DEV_PLUS_VID_NO_PAD
+               vconfig set_name_type DEV_PLUS_VID_NO_PAD > /dev/null
                VLANID=`echo $IFACE|sed "s/eth[0-9][0-9]*\.0*//g"`
                IF_VLAN_RAW_DEVICE=`echo $IFACE|sed 
"s/\(eth[0-9][0-9]*\)\..*/\1/"`
                ;;
@@ -37,7 +37,7 @@
                exit 1
        fi
        ip link set up dev $IF_VLAN_RAW_DEVICE
-       vconfig add $IF_VLAN_RAW_DEVICE $VLANID
+       vconfig add $IF_VLAN_RAW_DEVICE $VLANID > /dev/null
 fi
 
 # This is not vlan specific, and should actually go somewhere else.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to