On Tue, Jan 25, 2005 at 11:41:43PM -0500, Albert Cahalan wrote:
> Woah you're brave...
=)
> Adding a top-level common.h is wrong.
> See the proc/*.h files, including proc/procps.h.
Ah, I see.
> In general I'm moving away from PAGE_SIZE, but I
> sure do wish to keep it in minimal.c. Note that
> this file is not compiled in by default, and that
> it already supports FreeBSD.
Well, currently it hardcoded PAGE_SIZE to 4096 when undefined. I think
it's better to get it from system headers as FreeBSD (and GNU/kFreeBSD)
have it =)
> You should not remove stuff from the example
> sysctl.conf. It's commented out anyway.
Are your comments wrt debian or upstream? In the debian package, my patch
makes a copy of sysctl.conf. This way we only modify the
"sysctl.conf.kfreebsd-gnu" version so that linux-gnu systems are not affected.
(the linux-gnu defaults aren't much useful to kfreebsd's sysctl namespace).
> SIGPOLL is in the UNIX standard. SIGIO is not there.
> This suggests that FreeBSD is less of a UNIX than
> Linux is. :-) Please fix your kernel and/or libc.
The glibc manual says this about SIGPOLL:
This is a System V signal name, more or less similar to `SIGIO'.
It is defined only for compatibility.
... where the last phrase isn't really true -- this is a bug indeed.
As for standards, I know SIGIO is not mentioned but it doesn't hurt to support
it imho.
> Redefining LINUX_VERSION is a huge mistake. You may
> wish to change how linux_version_code is set though,
> perhaps based on __FreeBSD_kernel_version and some
> knowledge of how FreeBSD kernels match up with Linux
> kernels. Probably you want something like:
>
> linux_version_code = LINUX_VERSION(2,0,0);
Yes, Linux 2.0 is accurate for that.
> TAB3 is also part of the UNIX standard, in termios.h.
> It's not even part of the XSI feature set, but just
> a regular feature required of all POSIX systems.
I know. I wrote this down to fix it next time i hacked on Glibc.
> I can not find XTABS in the UNIX and POSIX standard.
Glibc defines it in <bits/ioctl.h>. It is barely documented but seems to be
the same as TAB3 (on linux-gnu, both macros are the same number).
> SIGPWR is not Linux-specific. AIX, HP-UX, IRIX, and
> Solaris all have it. Hopefully it will get into the next
> revision of POSIX. Here is the Solaris 9 description:
>
> Name Value Default Event
> SIGPWR 19 Ignore Power Fail or Restart
>
> The IRIX description is identical.
Looks like *BSD systems and GNU/k*BSD derivatives don't have it. Is there
any way to conditionalise its use in the code?
--
.''`. Proudly running Debian GNU/kFreeBSD unstable/unreleased (on UFS2+S)
: :' :
`. `' http://www.debian.org/ports/kfreebsd-gnu
`-
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
