severity 289633 critical thanks On Tue, Jan 11, 2005 at 01:21:45PM +0200, Tristan Seligmann wrote: > tag 289633 patch > done > > Perhaps I should have quoted the next sentence: > > If a script requires non-POSIX features from the shell interpreter, > the appropriate shell must be specified in the first line of the > script (e.g., #!/bin/bash) and the package must depend on the > package providing the shell (unless the shell package is marked > "Essential", as in the case of bash).
Sorry, saw that too late. Adjusted severity, since breaking every
logroation is even more severe than policy violation.
> > Will dash only write "-e" to the log? Or will it simply write -e
> > followed by the message, just without interpreting of the escape
> > characters?
>
> dash's echo always behaves like bash's echo with -e passed, so the
> result is that /etc/logrotate.d/atftpd contains:
>
> -e /var/log/atftpd.log {
> daily
> rotate 5
> compress
> copytruncate
> missingok
> }
>
> This is invalid syntax, and causes logrotate to error out:
>
> /etc/cron.daily/logrotate:
> error: atftpd:1 lines must begin with a keyword or a filename (possibly
> in double quotes)
> error: atftpd:7 unxpected }
> run-parts: /etc/cron.daily/logrotate exited with return code 1
>
> This breaks log rotation for every package on the system, not just
> atftpd. (critical severity?)
>
> I'm attaching a patch that fixes this bug.
Patch looks fine to me.
Greetings
Helge
--
Helge Kreutzmann, Dipl.-Phys. [EMAIL PROTECTED]
gpg signed mail preferred
64bit GNU powered http://www.itp.uni-hannover.de/~kreutzm
Help keep free software "libre": http://www.freepatents.org/
pgpTsY6kiCBA3.pgp
Description: PGP signature
