On Sun, 16 May 2010, Thorsten Glaser wrote:

> Cristian Ionescu-Idbohrn dixit:
>
> >What I have in mind is attached.
>
> Two comments:
>
> * The changes to the comments in libbsd-0.2.0.cii0/Makefile areā€¦ weird,e
>   especially in the ifeq case.

Could you please be more specific?

> * Do not use $(shell ./foo.sh), use $(shell sh foo.sh) instead, which
>   does not rely on the +x attribute (bad thing) and possibly saves
>   one invocation.

I just kept the same style as used at the top of that Makefile:

        VERSION := $(shell ./get-version)


-- 
Cristian



--
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/1005161653490.3...@somehost

Reply via email to