On Thu, Jun 26, 2008 at 05:53:07PM +0200, Frans Pop wrote: > > A few naming suggestions that IMO make the scripts better readable: > - s/toggle_bios/toggle_biosgrub/ (affects script directory name too) > - s/biosable/biosgrub/ > - s/unbiosable/nobiosgrub/ > - s/valid_bios/valid_biosgrub/ > > Should the description "BIOS boot area:" not also mention grub in some > way? Something like "Reserve BIOS boot area for GRUB:" (although that may > already be a bit long for this dialog)?
I don't think it's essential to mention GRUB; in theory, other bootloaders could want to replace GRUB in this partition whenever they're installed in MBR. (Yes, I think "bios_grub" flag name is an unfortunate choice of words, but HPA insisted in using it, and honestly I didn't mind that much) So we can just go by your preference. > From your initial mail it looks like: > - this will only work with grub-pc > - no additional changes are needed in grub-pc > - as grub-installer already automatically selects grub-pc for gpt, I guess > no additional changes are needed in grub-installer > > Is all that correct? Yes. -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What good is a phone call… if you are unable to speak? (as seen on /.) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
