On Saturday 03 May 2008, Ian Campbell wrote: > v2 patch is below. This looks reasonable. Essential characteristic of the patch is that bigmem is only proposed if: - the system has pae support - the installer itself is also running a bigmem kernel
One question: is pae something used by both Intel and AMD? I seem to recall that one had something different. In that case, should this be extended to also cover whatever the other manufacturer has? Please submit the final patch as a wishlist BR against base-installer with a link to this discussion in the mailing list archives. > Index: kernel/i386.sh > =================================================================== > --- kernel/i386.sh (revision 53021) > +++ kernel/i386.sh (working copy) > @@ -2,16 +2,24 @@ > VENDOR=`grep '^vendor_id' "$CPUINFO" | head -n1 | cut -d: -f2` > FAMILY=`grep '^cpu family' "$CPUINFO" | head -n1 | cut -d: -f2` > MODEL=`grep '^model[[:space:]]*:' "$CPUINFO" | head -n1 | cut -d: -f2` > + > + if grep '^flags' "$CPUINFO" | grep -q pae ; then > + case "$KERNEL_FLAVOUR" in > + 686-bigmem*) BIGMEM="-bigmem" ;; > + *) ;; > + esac > + fi This could do with a comment before the new code: # Only offer bigmem is the system supports pae and the installer # itself is also using a bigmem kernel Cheers, FJP
signature.asc
Description: This is a digitally signed message part.
