On Thursday 17 April 2008, James Westby wrote: > Attached is a patch that myself and Colin Watson worked on, based > on the patch from this bug report. It hopefully addresses all concerns > that were raised about the existing patch, and updates it to the > existing codebase. > > Please consider applying it. I would be happy to address any concerns > that you have with the patch.
After a quick glance a couple of things look wrong. You read password-crypted to see if it is preseeded. This value presumably already _is_ encrypted, but you still pass it through 'password --md5'. Also, why is the output of the password command _appended_ to the temp file? That would seem to break idempotency. In general, how well has this patch been tested, both for interactive use and preseeding? Has entering the password been tested after a reboot in both cases? Cheers, FJP -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
