On Thursday 05 October 2006 00:03, David Härdeman wrote: > >What's against bringing it back in the method dialog? > > Nothing, it's a matter of taste (meaning it's up to you to decide) :) > > The user would probably be left wondering which disk the last option > refers to...not knowing that the disk choice will be the subject of the > next dialogue?
I see what you mean, but I don't think it should be delayed. To be honest, I've never been really happy with the inconsistency that was decided on in that menu: having individual disks listed for the normal method, but not for the others. But I had kind of decided to let that pass for Etch. This issue brings it back though. I personally would prefer to consistently delay disk selection to a second level in _all_ cases and explain what the next step will be in the description; something like: <example> The installation system allows you to either automatically partition a disk for the new system (using different standard recipes), or set up partitions manually. If you choose to automatically partition an entire disk, you will next be asked which disk should be used. Partitioning method: Automatic - use the largest continuous free space Automatic - erase entire disk Automatic - erase entire disk and set up LVM Automatic - erase entire disk and set up encrypted LVM Manual </example> This may need to be revised again when we can offer RAID1, but that depends on the implementation and could probably be solved by mentioning that option in the description. It would probably be a could idea to repeat the fact that existing data will be erased after selecting a method that does and we need to add an extra confirmation dialog before the partition table is written when using LVM anyway (see #368633). BTW. I also noticed that with "Use the largest continuous free space" there is currently no indication of what disk will actually be used or how big the free space is. It is of course kind of implied (whichever disk has the largest free space), but IMO it would be kind of nice to tell the user before it is done.
pgpCbmut5mS5q.pgp
Description: PGP signature
