Jerry Haltom wrote: > The following patch to choose-mirror.c removes the need for the hard > coded PREFERRED_DISTRIBUTION variable by allowing it to be overridden > with a pre-seeded value (good for non-Debian Debian's (Ubuntu)).
I'm othered by the way this changes mirror/suite's value as part of the choose-mirror run and invites using non-suite values in it. As I understand it, your patch allows one to set eg, mirror/suite=etch. (Note that "etch" is not really a suite at all, but a distribution name.) Then choose-mirror will download http://mirror/debian/dists/etch/Release, and look for the Suite line in it. It will then set mirror/suite to testing and the install will proceed using that value. But since mirror/suite has changed during the install, you can't take the preseed log file from the install and reliably use it to reproduce the install. If etch becomes stable in the meantime, then you'll end up installing testing instead of etch. This might even cause problems if choose-mirror were re-run during the same install. Or maybe you want to set mirror/suite=testing from the beginning? The current code supports that, but it will still try to download http://mirror/debian/dists/sarge/Release only to throw it away. And I see how that's bad news for ubuntu. Would it be ok if we used a different variable: -+ debconf_get(debconf, DEBCONF_BASE "suite"); ++ debconf_get(debconf, DEBCONF_BASE "preferred_distribution"); Then we can set mirror/preferred_distribution to sarge in templates and remove PREFERRED_DISTRIBUTION altogether, and ubuntu can just preseed it. -- see shy jo
signature.asc
Description: Digital signature
