On Tue, Oct 19, 2004 at 12:33:36PM +0100, Colin Watson wrote: > On Mon, Oct 18, 2004 at 10:01:29PM -0700, Matt Kraai wrote: > > Package: partman-newworld > > Version: > > > > According to the partman manual, > > > > Packages that provide support for some file system should install a > > script in the directory > > <file>/lib/partman/valid_filesystems</file>. The first argument given > > to this script is some device directory, the second argument is the > > id of some partition and the third argument is one of the strings > > `formatable' and `existing'. If it is `formatable' then the job of > > the script is to check if the specified partition can be formatted > > and used. If the third argument is `existing' then the job of the > > script is to check if the partition can be used without formatting. > > In either case if the partition can be used then the script should > > print a line with the identifier of the type of the file system. > > > > partman-newworld's valid_filesystem script prints nothing unless the > > third argument is "newworld", in which case it prints "newworld". > > (I wonder if the valid_filesystems API has changed since I first wrote > partman-newworld?) > > Yes, this does seem to be a discrepancy. Is there a problem caused by > this, or did you just find it by code auditing? Since neither > "formatable" nor "existing" really make sense for partman-newworld, > perhaps its valid_filesystems script should just be removed.
I don't know if it causes a problem or not. I discovered it while trying to figure out what is causing bug 276741 (though I don't think that it's related). -- Matt -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
