Package: libdiscover2
Version: 2.1.2-10.1
Severity: minor
Tags: upstream

   * What led up to the situation?

     Checking for defects with a new version

test-[g|n]roff -mandoc -t -K utf8 -rF0 -rHY=0 -rCHECKSTYLE=10 -ww -z < "man 
page"

  [Use "groff -e ' $' -e '\\~$' <file>" to find obvious trailing spaces.]

  ["test-groff" is a script in the repository for "groff"; is not shipped]
(local copy and "troff" slightly changed by me).

  [The fate of "test-nroff" was decided in groff bug #55941.]

   * What was the outcome of this action?

an.tmac:<stdin>:1: style: .TH missing third argument; consider document 
modification date in ISO 8601 format (YYYY-MM-DD)
an.tmac:<stdin>:1: style: .TH missing fourth argument; consider package/project 
name and version (e.g., "groff 1.23.0")
troff:<stdin>:3: warning: trailing space in the line
troff:<stdin>:6: warning: trailing space in the line
troff:<stdin>:7: warning: trailing space in the line
troff:<stdin>:8: warning: trailing space in the line
troff:<stdin>:9: warning: trailing space in the line
troff:<stdin>:10: warning: trailing space in the line
troff:<stdin>:12: warning: trailing space in the line
troff:<stdin>:13: warning: trailing space in the line
troff:<stdin>:16: warning: trailing space in the line
troff:<stdin>:19: warning: trailing space in the line
troff:<stdin>:21: warning: trailing space in the line
troff:<stdin>:23: warning: trailing space in the line
troff:<stdin>:24: warning: trailing space in the line
troff:<stdin>:25: warning: trailing space in the line
troff:<stdin>:26: warning: trailing space in the line
troff:<stdin>:27: warning: trailing space in the line
troff:<stdin>:28: warning: trailing space in the line
troff:<stdin>:29: warning: trailing space in the line
troff:<stdin>:30: warning: trailing space in the line
troff:<stdin>:31: warning: trailing space in the line
troff:<stdin>:35: warning: trailing space in the line
troff:<stdin>:38: warning: trailing space in the line
troff:<stdin>:40: warning: trailing space in the line
troff:<stdin>:42: warning: trailing space in the line
troff:<stdin>:43: warning: trailing space in the line
troff:<stdin>:44: warning: trailing space in the line
troff:<stdin>:45: warning: trailing space in the line
troff:<stdin>:46: warning: trailing space in the line
troff:<stdin>:47: warning: trailing space in the line
troff:<stdin>:48: warning: trailing space in the line
troff:<stdin>:49: warning: trailing space in the line
troff:<stdin>:50: warning: trailing space in the line
troff:<stdin>:51: warning: trailing space in the line
troff:<stdin>:52: warning: trailing space in the line
troff:<stdin>:53: warning: trailing space in the line
troff:<stdin>:54: warning: trailing space in the line
troff:<stdin>:55: warning: trailing space in the line
troff:<stdin>:56: warning: trailing space in the line
troff:<stdin>:57: warning: trailing space in the line
troff:<stdin>:62: warning: trailing space in the line
troff:<stdin>:63: warning: trailing space in the line
troff:<stdin>:64: warning: trailing space in the line
troff:<stdin>:66: warning: trailing space in the line
troff:<stdin>:67: warning: trailing space in the line
troff:<stdin>:70: warning: trailing space in the line


   * What outcome did you expect instead?

     No output (no warnings).

-.-

  General remarks and further material, if a diff-file exist, are in the
attachments.


-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.12.12-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=is_IS.iso88591, LC_CTYPE=is_IS.iso88591 (charmap=ISO-8859-1), 
LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages libdiscover2 depends on:
ii  discover-data  2.2013.01.13+nmu1
ii  libc6          2.40-6
ii  libexpat1      2.6.4-1
ii  libusb-1.0-0   2:1.0.27-2

libdiscover2 recommends no packages.

libdiscover2 suggests no packages.

-- no debconf information
Input file is discover.conf.5

Output from "mandoc -T lint  discover.conf.5": (shortened list)

      1 input text line longer than 80 bytes: The file format is X...
      1 missing date, using "": TH
      4 skipping paragraph macro: PP after SH
      2 skipping paragraph macro: PP empty
     34 whitespace at end of input line

-.-.

Output from "test-groff -mandoc -t -ww -z discover.conf.5": (shortened list)

     45 trailing space in the line

-.-.

Show if docman-to-man created this.

Who is actually creating this man page?  Debian or upstream?

Is the generating software out of date?

71:.\" created by instant / docbook-to-man, Thu 31 Aug 2006, 11:05 

-.-.

Remove space characters (whitespace) at the end of lines.
Use "git apply ... --whitespace=fix" to fix extra space issues, or use
global configuration "core.whitespace".

Number of lines affected is

60

-.-.

Use a macro to change to the italic font, instead of \fI, if
possible (see man-pages(7)).
The macros have the italic corrections, but "\c" removes the "\/" part,
which is in the macro.
So "\/" must be added between the italic argument and the "\c" string.

  Or

add the italic corrections.

12:The file format is XML; the \fIDTD\fR     is provided with the 
\fBDiscover\fP software, and can be used for 

-.-.

Wrong distance between sentences in the input file.

  Separate the sentences and subordinate clauses; each begins on a new
line.  See man-pages(7) ("Conventions for source file layout") and
"info groff" ("Input Conventions").

  The best procedure is to always start a new sentence on a new line,
at least, if you are typing on a computer.

Remember coding: Only one command ("sentence") on each (logical) line.

E-mail: Easier to quote exactly the relevant lines.

Generally: Easier to edit the sentence.

Patches: Less unaffected text.

Search for two adjacent words is easier, when they belong to the same line,
and the same phrase.

  The amount of space between sentences in the output can then be
controlled with the ".ss" request.

Mark a final abbreviation point as such by suffixing it with "\&".

Some sentences (etc.) do not begin on a new line.

62:Josh Bressers, John R. Daily, and 
63:G. Branden Robinson developed the current implementation of 

-.-.

Split lines longer than 80 characters into two or more lines.
Appropriate break points are the end of a sentence and a subordinate
clause; after punctuation marks.

Line 12, length 108

The file format is XML; the \fIDTD\fR     is provided with the \fBDiscover\fP 
software, and can be used for 

-.-.

The name of a man page is typeset in bold and the section in roman
(see man-pages(7)).

3:discover.conf \(em configuration file format for discover(1) 
70:discover(1) 

-.-.

Remove quotes when there is a printable
but no space character between them
and the quotes are not for emphasis (markup),
for example as an argument to a macro.

1:.TH "discover.conf" "5" 
2:.SH "NAME" 
4:.SH "Description" 
14:.SH "Examples" 
60:.SH "Authors" 

-.-.

Space character after a macro call.

5:.PP 
11:.PP 
15:.PP 
17:.PP 
33:.PP 
34:.PP 
36:.PP 
59:.PP 
61:.PP 
65:.PP 
69:.PP 

-.-.

Output from "test-groff  -mandoc -t -K utf8 -rF0 -rHY=0 -rCHECKSTYLE=10 -ww -z 
":

an.tmac:<stdin>:1: style: .TH missing third argument; consider document 
modification date in ISO 8601 format (YYYY-MM-DD)
an.tmac:<stdin>:1: style: .TH missing fourth argument; consider package/project 
name and version (e.g., "groff 1.23.0")
troff:<stdin>:3: warning: trailing space in the line
troff:<stdin>:6: warning: trailing space in the line
troff:<stdin>:7: warning: trailing space in the line
troff:<stdin>:8: warning: trailing space in the line
troff:<stdin>:9: warning: trailing space in the line
troff:<stdin>:10: warning: trailing space in the line
troff:<stdin>:12: warning: trailing space in the line
troff:<stdin>:13: warning: trailing space in the line
troff:<stdin>:16: warning: trailing space in the line
troff:<stdin>:19: warning: trailing space in the line
troff:<stdin>:21: warning: trailing space in the line
troff:<stdin>:23: warning: trailing space in the line
troff:<stdin>:24: warning: trailing space in the line
troff:<stdin>:25: warning: trailing space in the line
troff:<stdin>:26: warning: trailing space in the line
troff:<stdin>:27: warning: trailing space in the line
troff:<stdin>:28: warning: trailing space in the line
troff:<stdin>:29: warning: trailing space in the line
troff:<stdin>:30: warning: trailing space in the line
troff:<stdin>:31: warning: trailing space in the line
troff:<stdin>:35: warning: trailing space in the line
troff:<stdin>:38: warning: trailing space in the line
troff:<stdin>:40: warning: trailing space in the line
troff:<stdin>:42: warning: trailing space in the line
troff:<stdin>:43: warning: trailing space in the line
troff:<stdin>:44: warning: trailing space in the line
troff:<stdin>:45: warning: trailing space in the line
troff:<stdin>:46: warning: trailing space in the line
troff:<stdin>:47: warning: trailing space in the line
troff:<stdin>:48: warning: trailing space in the line
troff:<stdin>:49: warning: trailing space in the line
troff:<stdin>:50: warning: trailing space in the line
troff:<stdin>:51: warning: trailing space in the line
troff:<stdin>:52: warning: trailing space in the line
troff:<stdin>:53: warning: trailing space in the line
troff:<stdin>:54: warning: trailing space in the line
troff:<stdin>:55: warning: trailing space in the line
troff:<stdin>:56: warning: trailing space in the line
troff:<stdin>:57: warning: trailing space in the line
troff:<stdin>:62: warning: trailing space in the line
troff:<stdin>:63: warning: trailing space in the line
troff:<stdin>:64: warning: trailing space in the line
troff:<stdin>:66: warning: trailing space in the line
troff:<stdin>:67: warning: trailing space in the line
troff:<stdin>:70: warning: trailing space in the line
  Any program (person), that produces man pages, should check the output
for defects by using (both groff and nroff)

[gn]roff -mandoc -t -ww -b -z -K utf8 <man page>

  The same goes for man pages that are used as an input.

  For a style guide use

  mandoc -T lint

-.-

  Any "autogenerator" should check its products with the above mentioned
'groff', 'mandoc', and additionally with 'nroff ...'.

  It should also check its input files for too long (> 80) lines.

  This is just a simple quality control measure.

  The "autogenerator" may have to be corrected to get a better man page,
the source file may, and any additional file may.

  Common defects:

  Not removing trailing spaces (in in- and output).
  The reason for these trailing spaces should be found and eliminated.

  Not beginning each input sentence on a new line.
Line length should thus be reduced.

  The script "reportbug" uses 'quoted-printable' encoding when a line is
longer than 1024 characters in an 'ascii' file.

  See man-pages(7), item "semantic newline".

-.-

The difference between the formatted output of the original and patched file
can be seen with:

  nroff -mandoc <file1> > <out1>
  nroff -mandoc <file2> > <out2>
  diff -d -u <out1> <out2>

and for groff, using

\"printf '%s\n%s\n' '.kern 0' '.ss 12 0' | groff -mandoc -Z - \"

instead of 'nroff -mandoc'

  Add the option '-t', if the file contains a table.

  Read the output from 'diff -d -u ...' with 'less -R' or similar.

-.-.

  If 'man' (man-db) is used to check the manual for warnings,
the following must be set:

  The option \"-warnings=w\"

  The environmental variable:

export MAN_KEEP_STDERR=yes (or any non-empty value)

  or

  (produce only warnings):

export MANROFFOPT=\"-ww -b -z\"

export MAN_KEEP_STDERR=yes (or any non-empty value)

-.-

Reply via email to