Your message dated Sun, 5 Jan 2025 10:57:52 +0100
with message-id <0769ce2d-3b5b-4643-9554-ea45bac9d...@plouf.fr.eu.org>
and subject line Re: Bug#995209: d-i: partman-basicfilesystems: missing btrfs
mount option descriptions
has caused the Debian Bug report #995209,
regarding d-i: partman-basicfilesystems: missing btrfs mount option descriptions
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
995209: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995209
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: partman-basicfilesystems
Version: 156
Tags: patch
Hello d-i team,
The following mount options are advertised in mountoptions/btrfs from
package partman-btrfs but lack descriptions in
debian/partman-basicfilesystems.templates :
nodatasum
nodatacow
nobarrier
compress
ssd
noacl
notreelog
flushoncommit
Also, select_mountoptions wrongly stops reading the option list when
encountering a missing description, skipping all remaining options
instead of just skipping options with no description. I spotted this
because the "discard" option is not available for btrfs even though it
has a description and is available for other filesystems which support
it (ext4, fat*).
For now, the attached patch does not skip any options and just shows
bare options instead of the missing descriptions.
Q: Which package should provide the descriptions for filesystem-specific
mount options ? partman-basicfilesystems or partman-<filesystem> ?
--- a/select_mountoptions 2021-07-23 19:14:05.000000000 +0200
+++ b/select_mountoptions 2021-09-27 22:37:28.609316256 +0200
@@ -24,12 +24,13 @@
for op in $(cat $optionsfile); do
if db_metaget partman-basicfilesystems/text/$op description && \
[ "$RET" ]; then
- all_options="${all_options:+$all_options, }$op"
- descriptions="${descriptions:+$descriptions, }$RET"
+ :
else
- logger -t partman "Error: no description for mount option $op found; skipping"
- break
+ logger -t partman "Error: no description for mount option $op found"
+ RET="$op"
fi
+ all_options="${all_options:+$all_options, }$op"
+ descriptions="${descriptions:+$descriptions, }$RET"
if [ -f $part/options/$op ]; then
full_options="${full_options:+$full_options,}$(cat $part/options/$op)"
--- End Message ---
--- Begin Message ---
Version: 167
Fixed by commit 19772efb "Do not skip options if description is missing,
just show option name".
--- End Message ---
