Your message dated Wed, 01 Jan 2025 21:19:03 +0000
with message-id <e1tt67l-00d22m...@fasolo.debian.org>
and subject line Bug#1035085: fixed in grub-installer 1.205
has caused the Debian Bug report #1035085,
regarding Bookworm RC2 grub-installer/os-prober quirks
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1035085: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1035085
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: grub-installer
Version: 1.190
Severity: minor
Tags: patch
Boot method: USB stick
Image version: debian-bookworm-DI-rc2-amd64-netinst.iso
Installation type: expert install
Date: 2023-04-29
Hello,
I observed a few minor quirks while testing the new os-prober
re-enablement feature.
1) In expert install (or low priority), the new os-prober dialog
displayed by grub-installer lists only unsupported OS but not supported OS.
(Patch attached)
2) "efi" os-prober type is considered unsupported.
In EFI mode, os-prober detects EFI boot loaders such as Windows Boot
Manager with type "efi". GRUB can add menu entries for these boot
loaders so this type should be in the supported list instead of the
unsupported list. (AFAICS it does not matter much because the supported
OS list is used only when installing GRUB for legacy boot and not EFI boot.)
(Patch attached)
3) Changing the previous answer to "Run os-prober automatically to
detect and boot other OSes" does not work as expected.
Steps to reproduce:
- Start a new expert install.
- At the question "Run os-prober automatically to detect and boot other
OSes", answer "yes".
- Go back to the main menu and select "Install the GRUB boot loader" again.
- At the question "Run os-prober automatically to detect and boot other
OSes", answer "no".
Result: changing the previous answer to "no" does nothing:
grub2/enable_os_prober and /target/etc/default/grub are unchanged so
os-prober will still be run.
- Start a new expert install.
- At the question "Run os-prober automatically to detect and boot other
OSes", answer "no".
- Go back to the main menu and select "Install the GRUB boot loader" again.
- At the question "Run os-prober automatically to detect and boot other
OSes", answer "yes".
Result: Changing the previous answer to "yes" does half the job:
grub2/enable_os_prober is changed but /target/etc/default/grub is
unchanged so os-prober will not be run.
IIUC, this is because
- answering "no" is a no-op;
- grub2/enable_os_prober has an effect only when /target/etc/defaut/grub
is generated by the selected grub-* package config script when the
package is installed (after the first time the question is asked).From c117406bf936e0fd4ff3f31916b1cd22db3f46ed Mon Sep 17 00:00:00 2001
From: Pascal Hambourg <pas...@plouf.fr.eu.org>
Date: Sat, 29 Apr 2023 09:35:42 +0200
Subject: [PATCH 1/2] Add all other OS to the complete OS list, not only
unsupported OS
---
grub-installer | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/grub-installer b/grub-installer
index 2f0de04d..3c177c41 100755
--- a/grub-installer
+++ b/grub-installer
@@ -566,6 +566,11 @@ if [ -s /tmp/os-probed ]; then
IFS="$OLDIFS"
title=$(echo "$os" | cut -d: -f2)
type=$(echo "$os" | cut -d: -f4)
+ if [ -n "$other_os_list" ]; then
+ other_os_list="$other_os_list, $title"
+ else
+ other_os_list="$title"
+ fi
case "$type" in
chain)
: ;;
@@ -579,11 +584,6 @@ if [ -s /tmp/os-probed ]; then
else
unsupported_os_list="$title"
fi
- if [ -n "$other_os_list" ]; then
- other_os_list="$other_os_list, $title"
- else
- other_os_list="$title"
- fi
continue
fi
;;
@@ -595,11 +595,6 @@ if [ -s /tmp/os-probed ]; then
else
unsupported_os_list="$title"
fi
- if [ -n "$other_os_list" ]; then
- other_os_list="$other_os_list, $title"
- else
- other_os_list="$title"
- fi
continue
;;
esac
--
2.30.2
From 005333adb8d1f57a0620cac3206aaa78b7be0136 Mon Sep 17 00:00:00 2001
From: Pascal Hambourg <pas...@plouf.fr.eu.org>
Date: Sat, 29 Apr 2023 09:38:58 +0200
Subject: [PATCH 2/2] Add "efi" os-prober type to the supported OS list
In EFI mode, os-prober detects EFI boot loaders such as Windows boot
manager with type "efi". grub-mkconfig can add menu entries for these
boot loaders so this type should be in the supported list.
(It does actually not matter much because the supported OS list is used
only when installing GRUB for legacy boot and not EFI boot)
---
grub-installer | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-installer b/grub-installer
index 3c177c41..afd65a26 100755
--- a/grub-installer
+++ b/grub-installer
@@ -572,7 +572,7 @@ if [ -s /tmp/os-probed ]; then
other_os_list="$title"
fi
case "$type" in
- chain)
+ chain|efi)
: ;;
linux)
# Check for linux systems that we don't
--
2.30.2
--- End Message ---
--- Begin Message ---
Source: grub-installer
Source-Version: 1.205
Done: Holger Wansing <hwans...@mailbox.org>
We believe that the bug you reported is fixed in the latest version of
grub-installer, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1035...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Holger Wansing <hwans...@mailbox.org> (supplier of updated grub-installer
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 01 Jan 2025 21:52:10 +0100
Source: grub-installer
Architecture: source
Version: 1.205
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Holger Wansing <hwans...@mailbox.org>
Closes: 1035085 1086750 1086840 1091441
Changes:
grub-installer (1.205) unstable; urgency=medium
.
* Team upload.
.
[ Pascal Hambourg ]
* Fixes for some grub-installer/os-prober quirks (Closes: #1035085):
* In expert install, the os-prober dialog shows only unsupported OS but
not supported OS.
* "efi", "macosx" and "minix" os-prober types are added to the unsupported
OS list although GRUB os-prober helper script can add menu entries for
them, so these types should be added to the supported OS list instead.
* os-prober is needlessly enabled by default when only unsupported OS are
detected.
* Do not ask about os-prober again on subsequent runs; it would not have
any effect at all.
* Remove grub-legacy support. (Closes: #1086750, #1086840)
* Some additional code clean-up.
* isinstallable: Exclude non-EFI armhf. (Closes: #1091441)
.
[ Updated translations ]
* Belarusian (be.po) by vics
* Persian (fa.po) by Danial Behzadi
* Hungarian (hu.po) by Szia Tomi
* Icelandic (is.po) by Sveinn í Felli
* Dutch (nl.po) by Frans Spiesschaert
* Occitan (oc.po) by Quentin PAGÈS
* Romanian (ro.po) by Remus-Gabriel Chelu
* Tamil (ta.po) by TamilNeram
* Turkish (tr.po) by Fatih Altun
Checksums-Sha1:
c15dfc9bd2fd2816899cbb806196509583fdf58e 2081 grub-installer_1.205.dsc
99952732dbceb8982898ce91b975bf46682004ce 235572 grub-installer_1.205.tar.xz
ec80ae15f3babfff52a698e071a0e9ffad0eaa4e 6509
grub-installer_1.205_amd64.buildinfo
Checksums-Sha256:
1924d2c2f2ad29f8fa445c68a977f67e533fd8f86ff545bc9cbaa28e71a3c5de 2081
grub-installer_1.205.dsc
732b54deb0252e707511d0b8168d1772509cf1765d44c498a34ba1e2b41de74c 235572
grub-installer_1.205.tar.xz
4160d749385b8958d782461287a040d867c239408e8a7f53abcaab0080766f33 6509
grub-installer_1.205_amd64.buildinfo
Files:
f2015dbf39ddd08154e7493df47885ad 2081 debian-installer standard
grub-installer_1.205.dsc
a9ea872b985770a1cfd0390e1934f539 235572 debian-installer standard
grub-installer_1.205.tar.xz
a65f78efcd9576353996fae6b4b1a6e0 6509 debian-installer standard
grub-installer_1.205_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJJBAEBCgAzFiEESWrG6BRCSzSFCDUpWfGHyhVusHYFAmd1rNIVHGh3YW5zaW5n
QG1haWxib3gub3JnAAoJEFnxh8oVbrB2BYIP/0b/4aP2ldfb+mJ4ALPc34oyB5ke
R4i9bs9qn0e1Pp8t9BwAqOyhizbAA/GSKWNWn7evBitG1zRCwU9evTd8UK33Eatr
sK5k4P7hZnxofvjAdyp2JF8tiJNqyWEqFvUGd6gu6OAtPC/4qP9pPu17eiLFlmkx
zH79FfXOH23JKRyGIpkMrwaM3lIm8ChS2iG/aIP+mueAMDRUCB8Jsjomyl5F0oPs
ZVksUR3Ok7QzKObnLPcmL/BcbuVca8po5LlD4ZYRUy/n3lLTPVq562e1MEwLuLPX
w/aRrb8Fp+BlhVAgG+8Q8Wl4Sbs7TaUE9OmvNsgnzQ0RzSkuYRPjP2Fzx+uzTrV+
Zg5RjO+skzs4pN8omE+8atknSWcEgfQsEv434giifqfx1Pr7b2J0wNihDBPEhWfC
H509Yk5g7SSLdaIfw+s6PWwXrJZC/hEA/ZkLwAAInpqTiYfSl6Wz8k3Gh4xobGqf
UuL25kucYgmt3SuEvONIYvh2igWSg+XBxJInlFeY2xiSDh2PV1W0b6xH3xH8wDCd
4h64LPhkackWrz7/DGADuI6u0fcZxT/sWdkLQPz9TAsxxFZlY+H5hXeri9ZXiR5A
+3UcNwjDKy9CfCHzcTzyrvSkusFgbUL9eUkUNVBJPznxmfRHEmMHETAKacr/yqB1
/YXOIxrDq4qAoRGE
=P4+4
-----END PGP SIGNATURE-----
pgpGGdmd1y6Ry.pgp
Description: PGP signature
--- End Message ---
