Hi Adrian,
On 20/11/2024 at 14:02, John Paul Adrian Glaubitz wrote:
Can you elaborate on this a little more to explain the background?
I thought the initial bug submission provided enough background.
Some arm64 platforms need the 'legacy_boot' flag to boot on GPT but
support of this flag was missing in partman. Support was added for
guided/automatic partitioning in partman-auto but is still missing for
manual partitioning.
As part of supporting the 'legacy_boot' flag, manual partitioning needs
to do the same as what it does for the 'boot' flag:
- show the state of the flag in the main view
- add an option to toggle the flag in the partition settings view
The 'legacy_boot' flag exists only on GPT and the 'boot' flag is
irrelevant on GPT (it just reflects the 'esp' flag set on EFI system
partitions). So instead of adding new visuals for the 'legacy_boot'
option, it should be possible to use the same visuals as the 'boot' flag:
- GPT: use visuals with the 'legacy_boot' flag
- other disk labels: use visuals with the 'boot' flag
Doesn't this affect partman-efi only?
It does not affect partman-efi but it may be affected by it it depending
on the chosen implementation because partman-efi touches the 'bootable'
flag file used by partman-base to display the 'B' marker.
In any case partman-efi should not touch the 'boot' flag (the 'esp' flag
is enough) nor the 'bootable' flag file: on MSDOS the 'boot' flag is
independent and irrelevant for ESP partitions and on GPT it is redundant
and just reflects the 'esp' flag. The current interaction between
partman-efi and partman-base has unexpected side effects. Fixing this is
also part of my plans.