On Mon, May 27, 2024 at 2:02 PM Tyler Stachecki <stachecki.ty...@gmail.com> wrote: > > On Thu, Feb 22, 2024 at 09:16:24AM +0100, Lucas Bonnet wrote: > > > > Hello dear Debian maintainers, > > > > I can confirm that the 2020 patch from Carsten Schoenert still applies > > to d-i/netcfg releases 1.187 and 1.188, and result in a debian installer > > that knows about VLANs and can be fully automated with a preseed config > > like the following: > > > > d-i netcfg/enable boolean true > > d-i netcfg/use_vlan boolean true > > d-i netcfg/vlan_id string 1001 > > d-i netcfg/choose_interface select ens3f0np0 > > > > > > We would be interested in helping push the patch upstream so that other > > users can enjoy this without having to build and make their own initrd, > > how can we help? > > > > > > Regards, > > -- > > Lucas Bonnet > > Bearstech - http://bearstech.com > > > > Sorry, I have to disagree with you here -- the patch certainly does not apply > cleanly anymore. Even after fixing it up, I faced installation issues as it > attempts to add the VLAN subinterface twice, and fails the second time due to > it already existing. > > The VLAN code does not use ioctls/netlink and instead shells out to ip link/ > ifconfig for Linux and FreeBSD respectively. I took a quick look at what it > would take to shift this code over to ioctls, but it seems there are inherent > differences in the ioctl interface between the two OS-es that would make it > non-trivial to support both at that level. I would be curious to hear the > maintainers feedback as to whether or not this is acceptable. > > I'm attaching a patch that applies cleanly against 1.188 and was tested > against a patched bookworm initrd with success. > > Cheers, > Tyler
Hi, Sorry -- turns out this was a little rash on my part: the patch from 2020 applies to 1.188 with fuzz but not 1.889 (which is what I had checked out). Anywho - the patch I attached previously applies cleanly to 1.189 and I am similarly happy to act on any feedback from the maintainer to carry this one across the line. Cheers, Tyler
