Hi, Quoting Tianon Gravi (2020-03-13 08:05:11) > On Thu, 12 Mar 2020 at 18:27, Cyril Brulebois <k...@debian.org> wrote: > > The latest batch of bug reports filed by Johannes 'josch' Schauer seems > > to confirm my initial assessment: this will break (too) many use cases > > (#953404, #953588, #953593, #953594, #953617). > +1, thanks (to you both) for doing this -- my first thought seeing these > changes was that this would have a pretty strong negative effect on the > debian-installer (especially folks using the larger CDs to avoid the > internet). > > I wonder if we could reasonably hook up josch's mmdebstrap tests via Salsa's > CI for MRs and commits to debootstrap? That seems like it would help avoid > these types of regressions for adding new features like this in a safer > manner.
better write a more comprehensive autopkgtest suite for debootstrap and test for the things that you are actually interested in. To find the problems this commit introduced, it would've been enough to add simple smoke tests for each of the debootstrap options (mmdebstrap only tests few of them) and then run debootstrap for unstable, testing, stable and oldstable -- verifying that they give a non-zero exit code. The plan for mmdebstrap is to go away once there is the "apt-get bootstrap" command at some point in the future. Also, mmdebstrap's test can break for a multitude of other reasons unrelated to debootstrap, so this is not a good idea. Thanks! cheers, josch
signature.asc
Description: signature
