On 03/03/2020 18:51, Cyril Brulebois wrote:
partman-* is of course fine for udebs shipping partman stuff, but depthcharge-support-installer strikes me as something that could be named depthcharge-support-udeb, or maybe just depthcharge-udeb?
I mimicked the flash-kernel & flash-kernel-installer naming for the latter two, and *-installer seems to be the way bootloader-related udeb packages are usually named (e.g. {grub,lilo,zipl}-installer currently in the archive). But I will change it if you're not convinced -- I think depthcharge-support-udeb is OK, but depthcharge-udeb feels weird as this is definitely not depthcharge itself (see below).
Maybe I can merge depthcharge-support into depthcharge-tools, it's just the easiest way I had thought of indicating "use this bootloader" like grub-* packages do (vs. grub-*-bin packages); then we could just have a depthcharge-tools and depthcharge-tools-installer/depthcharge-tools-udeb whichever is better.
(Unfortunately I don't have any time to review this more thoroughly to figure out exactly which part does what etc., but I thought sending this quick note wouldn't hurt.)
Thanks for the reply. I tried to write up a somewhat short overview of what my prospective packages do, to hopefully make things easier to understand:
Depthcharge is a coreboot payload from Google which is shipped as part of ChromeOS devices' firmware. It boots from images of a special format written to partitions of a special type.
partman-cros: - enables partman to create these partitions - checks and alerts if these partitions are necessary but don't exist depthcharge-tools provides scripts/commands that automate e.g.: - building images for a known current machine or an arbitrary config - writing images to partitions and setting boot priority - blessing the currently booted partition depthcharge-support only consists of: - initramfs & kernel hooks to build and write an up-to-date image - init.d script & systemd service to bless only successful boots depthcharge-support-installer is an installer step that: - installs depthcharge-tools to target - makes target build and write an image for itself - reconfigure initramfs if it's too big (machine-specific size limit) - installs depthcharge-support if all is fine