Package: console-setup
Version: 1.189
Severity: normal
Tags: patch
/bin/setupcon and /usr/bin/ckbcomp-mini are both shell scripts that
are minified (preprocessed to remove comments, whitespace and
indenting) before being shipped in the udeb.
/usr/lib/base-installer.d/20console-setup and
usr/share/console-setup/keyboard-configuration.config
setupcon is a 38K script before minifying and 22K afterwards. It's
extremely difficult to read to work out what on earth it is doing when
in that state, and this is sometimes necessary (e.g. when debugging
debian-installer). ckbcomp-mini goes from 5.4K to 3.3K keyboardconfiguration
from 47K to 44K
The debian config and postinst scripts get the same treatment (in the
conventional and udeb packages
Why are we minifying these scripts? Perhaps it made sense once to
squeeze the size of console-setup by a few K (maybe 24?), but it seems
very unlikely to be useful any more, given the cost of making
comprehension of the code almost impossible.
Attached is a patch to stop doing this. (It makes the udeb 6K bigger)
commit dac59c59d9a71612e8a1fbca744ba3b53f57663e
Author: Wookey <woo...@wookware.org>
Date: Sat Feb 23 04:10:42 2019 +0000
Stop minifying shell scripts
diff --git a/debian/changelog b/debian/changelog
index ea8a91d..c43b1db 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+console-setup (1.190) unstable; urgency=medium
+
+ * Stop minifying shell scripts
+
+ -- Wookey <woo...@debian.org> Sat, 23 Feb 2019 03:23:03 +0000
+
console-setup (1.189) unstable; urgency=medium
* Team upload
diff --git a/debian/preprocessor b/debian/preprocessor
index a9c3aa5..9571309 100755
--- a/debian/preprocessor
+++ b/debian/preprocessor
@@ -94,11 +94,6 @@ else
}' "$file" >$tmp && cat $tmp >"$file"
fi
-if [ "$mini" ]; then
- sed -e 's/^[ \t]*//' -e 's/^#[^!].*//' -e 's/^#$//' <"$file" >$tmp \
- && grep . $tmp >"$file"
-fi
-
rm $tmp
exit 0
