On Sat, 24 Feb 2018 21:11:53 +0100 Raphael Hertzog <hert...@debian.org> wrote: > > I've made a PoC patch for this issue > > - relocate scripts files to each distro directroy > > I think this is not a good idea. The location of the scripts file is part > of the public interface since debootstrap takes a script file > as 4th parameter.
It is only in source package, all scripts files are put into same /usr/share/debootstrap/scripts directory. It'd be nice to add another distro to add scripts directory in the future. Not necessary but nice, IMO. > Or maybe it's a good idea because we are going to have collisions one day > between codenames of the various distributions but then you have to keep > the current files for a little longer and you probably should consider > further changes so that we can pass "debian/sid" or "kali/kali-rolling" > as 1st parameter (suite). It would break current usage of debootstrap, so I would like to avoid it. > But this is also not required to implement this: > > > - split code from scripts/debian/sid > > This part looks fine from a cursory review. Thanks, it is also good for archived Debian releases like squeeze. -- Regards, Hideki Yamane henrich @ debian.org/iijmio-mail.jp