* Dominique Dumont <d...@debian.org> [2016-09-15 08:06]: > I guess that the intent is to let user know the the right DTB for his board > is > sun7i-a20-olinuxino-lime.dtb but this file cannot be found in the expected > location (which is I guess /boot).
No, it's usually found under /usr/lib/linux-image-$kvers (it ships with the kernel) but flash-kernel also allows users to put DTBs in /etc/flash-kernel/dtbs (flash-kernel will take the DTB from there and then store it under /boot for the boot process.) > I think this require some context knowledge from user to intepret > this correctly. I think also that indicating where the DTB file is > expected would give user a hint to look for an issue with kernel > installation or kernel content. > How about something like: > # flash-kernel > This board requires DTB file: sun7i-a20-olinuxino-lime.dtb > Couldn't find sun7i-a20-olinuxino-lime.dtb in /boot We could definitely do: > This board requires DTB file: sun7i-a20-olinuxino-lime.dtb > Couldn't find sun7i-a20-olinuxino-lime.dtb It's harder to specify the location because there are several options (find_dtb_file accepts absolute paths, and there's /usr/lib/linux-image-$kvers and /etc/flash-kernel/dtbs) Looking at the code, all uses of find_dtb_file() check for the result and produce an error if the file doesn't exist, so maybe we should just move the error messages into find_dtb_file(). Then we could tell the user where we were looking. Ian, any comments? -- Martin Michlmayr http://www.cyrius.com/