Your message dated Mon, 22 Feb 2016 19:49:06 +0000 with message-id <e1axwti-0006hi...@franck.debian.org> and subject line Bug#807708: fixed in flash-kernel 3.59 has caused the Debian Bug report #807708, regarding Implicitly overrides version number without --force to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 807708: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=807708 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: flash-kernel Version: 3.52 Tags: patch When you run flash-kernel with a specific version number, it will simply ignore the version number if there's a higher version unless you use --force. I think flash-kernel should at least print a warning in this case. tbm@debian:~$ sudo flash-kernel 4.2.0-1-kirkwood [sudo] password for tbm: kirkwood-qnap: machine: QNAP TS219 family DTB: kirkwood-ts219-6281.dtb Installing kirkwood-ts219-6281.dtb into /boot/dtbs/4.2.0-1-kirkwood/kirkwood-ts219-6281.dtb Taking backup of kirkwood-ts219-6281.dtb. Installing new kirkwood-ts219-6281.dtb. Installing kirkwood-ts219-6281.dtb into /boot/dtbs/4.4.0-rc4-kirkwood/kirkwood-ts219-6281.dtb Taking backup of kirkwood-ts219-6281.dtb. Installing new kirkwood-ts219-6281.dtb. flash-kernel: installing version 4.4.0-rc4-kirkwood flash-kernel: appending /usr/lib/linux-image-4.4.0-rc4-kirkwood/kirkwood-ts219-6281.dtb to kernel When I tried to add a warning, I noticed that there's some similar code, so I combined it into one block. (Note that I dropped the -n "$kvers" check since there's a comparison between $kvers and $latest_version anyway, but maybe that's wrong). The only remaining problem is that it installs the .dtb of the old kernel before changing the kernel version and installing the new .dtb. I'm not familiar with the code so I'm not sure if we can move the first handle_dtb call down or the version change up. Anyway, with this patch you get: root@debian:/home/tbm# flash-kernel 4.2.0-1-kirkwood kirkwood-qnap: machine: QNAP TS219 family DTB: kirkwood-ts219-6281.dtb Installing kirkwood-ts219-6281.dtb into /boot/dtbs/4.2.0-1-kirkwood/kirkwood-ts219-6281.dtb Taking backup of kirkwood-ts219-6281.dtb. Installing new kirkwood-ts219-6281.dtb. Ignoring old or unknown version 4.2.0-1-kirkwood (latest is 4.4.0-rc4-kirkwood) Use --force if you want version 4.2.0-1-kirkwood. Installing kirkwood-ts219-6281.dtb into /boot/dtbs/4.4.0-rc4-kirkwood/kirkwood-ts219-6281.dtb Taking backup of kirkwood-ts219-6281.dtb. Installing new kirkwood-ts219-6281.dtb. -- Martin Michlmayr http://www.cyrius.com/diff --git a/functions b/functions index 5829d51..b6713b5 100644 --- a/functions +++ b/functions @@ -637,10 +637,6 @@ if [ -n "$kvers" ] ; then fi latest_version=$(linux-version list | linux-version sort | tail -1) -if [ -n "$kvers" ] && [ "x$force" != "xyes" ] && [ "$kvers" != "$latest_version" ] && [ "$FK_KERNEL_HOOK_SCRIPT" = "postinst.d" ]; then - echo "Ignoring old or unknown version $kvers (latest is $latest_version)" >&2 - exit 0 -fi if [ -n "$kvers" ] && [ "$FK_KERNEL_HOOK_SCRIPT" = "postrm.d" ]; then echo "flash-kernel: Kernel ${kvers} has been removed." >&2 @@ -663,6 +659,11 @@ if [ "$kvers" != "$latest_version" ] && [ "x$force" = "xyes" ]; then echo "flash-kernel: forcing install of ${kvers} instead of ${latest_version}." >&2 echo "flash-kernel: WARNING: Installing any new kernel package might override this." >&2 else + echo "Ignoring old or unknown version $kvers (latest is $latest_version)" >&2 + if [ "$FK_KERNEL_HOOK_SCRIPT" = "postinst.d" ]; then + exit 0 + fi + echo "Use --force if you want version $kvers." >&2 kvers="$latest_version" # Make sure we install the DTB for $latest_version handle_dtb
--- End Message ---
--- Begin Message ---Source: flash-kernel Source-Version: 3.59 We believe that the bug you reported is fixed in the latest version of flash-kernel, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 807...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Christian Perrier <bubu...@debian.org> (supplier of updated flash-kernel package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 22 Feb 2016 18:52:43 +0100 Source: flash-kernel Binary: flash-kernel flash-kernel-installer Architecture: source Version: 3.59 Distribution: unstable Urgency: medium Maintainer: Debian Install System Team <debian-boot@lists.debian.org> Changed-By: Christian Perrier <bubu...@debian.org> Description: flash-kernel - utility to make certain embedded devices bootable flash-kernel-installer - Make the system bootable (udeb) Closes: 807708 813995 Changes: flash-kernel (3.59) unstable; urgency=medium . [ Uwe Kleine-König ] * use nandwrite when writing to nand flash. (Closes: #813995) . [ Martin Michlmayr ] * Require --force when invoked by hand with a specific version which is not the latest. (Closes: 807708) . [ Ian Campbell ] * Support $LINUX_KERNEL_CMDLINE_DEFAULTS via /etc/defaults/flash-kernel. This will be prepended to the ${bootargs} and can therefore be overridden by the firmware configuration. Suggested as part of #813023. * Fix debug logging intended to help with #781742. . [ Vagrant Cascadian ] * Update db entry for Firefly-RK3288 to allow armmp-lpae. Checksums-Sha1: 2e064690525d63dd8ce0b38f3d57f18407c57cad 1859 flash-kernel_3.59.dsc 8fb1cbf63ecf63b229ed9d522f73971574ecfa60 65664 flash-kernel_3.59.tar.xz Checksums-Sha256: d1178363e3444a267fd12e86f4006be432517d29e2115beb3406e70a03222d56 1859 flash-kernel_3.59.dsc 6db26f4acae5afd4ef6853b0dbd1f8fcf379832326c0bedf7a9d86003913f548 65664 flash-kernel_3.59.tar.xz Files: fa838a494720eb63849a13e9790ffa88 1859 utils optional flash-kernel_3.59.dsc c44e3714387de4a7fa5aba54d8ed944e 65664 utils optional flash-kernel_3.59.tar.xz -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJWy2N5AAoJEIcvcCxNbiWoH9kQALyETjASn52+umjErlLT4doy 9WRBidaCi+1i0cMpdPXJ8TxUl8tFWuFFLbaKA4m+0Cv9cZdjb65tN9tpHLwsnkm7 e2iUeu6NWCs2F3rCI6BAgnDb6aazvHMQxaWwJgtSBsZvR23HyHSsBmBrC/+8W1wG Pe+CvdqurksBsCUJR8QkSXBSFkTUNks5/m8pbjbvFjMPkMjZX/avV5xmpShTdIql nYDqumVxS21tCRmvK8bekgZo66xDNAiPAvwUx3DxifFO2Ef7H7FKROtqL7tA/j9t RysxFFoKSA4e3F/B88sHfw2cA4xWJD1QvGPscLQJr4TF4HZhUCLkntZR9wFVhZpe GEtuH2d9IOVsVTWFDDTsBHoZEs2B0wcn1oAQjLWhyQ25BEfU2R2z7FctAgVmyYa1 23Xf/mGlGjYu9DWuJrzlb0tJvRp7L3GanCgk/3KErdAgOL5/xvrf2PwvD2qRLeqb W/4iJG/KoiHaidq4VoB7fzKGVbqLA/7ggNzeZXaKzOF4avGWu0V1+SeyuwNdnWa3 4qQda3gjqEHf75MMQv3mF7Vtozyh5qdVBbf1DIO2obrmgWlo7BvIjF1SkFjslUks O20x59gQ3RQFzelc9c2hUxrF80bgsIA6JPsMKb40wehIod2Zd7T8tM0wCG79DL5P rTIk33iEfcv1IPvzcBHC =D1Gp -----END PGP SIGNATURE-----
--- End Message ---
