Hi adrian15,

On 18.08.2015 10:47, adrian15 wrote:
> Can you please explain why you are using: get_fstype () function which it's 
> based
> on blkid instead of just using the old method of relying in auto function 
> from the kernel itself?

The reason is simply that 'mount -tauto' didn't work, while explicitly 
specifying the
type found with blkid works fine.

Doing some archeology reveals the relevant error messages from syslog:
With 'mount -tauto':
kernel: [  109.257009] UDF-fs: warning (device sda9): udf_fill_super: No 
partition found (1)
kernel: [  109.378443] FAT-fs (sda9): utf8 is not a recommended IO charset for 
FAT filesystems, filesystem will be case sensitive!
main-menu[550]: (process:4539): mount: mounting /dev/sda9 on /media failed: 
Invalid argument

With blkid:
[   80.943104] EXT4-fs (sda9): mounted filesystem with ordered data mode. Opts: 
(null)

These happened during check_missing_firmware, i.e. this comes from mountmedia.
I think that convinced me not to use 'mount -t auto' in cdrom-detect.

However, that was two years ago. Much could have changed in the meantime.

> This is used in both cdrom-detect.patch and mountmedia.patch.
> 
> Please, be aware, that I'm not telling you your approach is incorrect. It 
> seems we are lacking
> the explanation or rationale on why you made that decision in order to 
> evaluate that change in a fair manner.

I'm curious: Why are you asking that now?

Best regards,
Andreas

Reply via email to