On Wed, Mar 04, 2015 at 05:22:22PM +0100, Cyril Brulebois wrote: > Wow, I'm glad I had been busy with other bits while you were discovering > this. This seems spot-on!
I was just looking at the code and was trying to understand what was initializing the structure when I suddenly noticed that no one else in the function was using that part. > And your hypothesis seems totally plausible, let's look at > d56c74f310b02af4f81e5f5a5ba65b55fdbdc34e[1]: > | Adapt parted_server code to handle new GNU Parted swap filesystem handling. > | > | r59025 > > 1. > http://anonscm.debian.org/cgit/d-i/partman-base.git/commit/?id=d56c74f310b02af4f81e5f5a5ba65b55fdbdc34e > > I could imagine how tempting it would be to copy-paste between > partition_info() and command_get_file_system(). The former deals with > part->[…] stuff, while the latter deals with fstype. And the function just happens to have a part->fs_type available so you don't get a compile error. > I'm very tempted to get the fix uploaded ASAP so that people can toy > around, even if I don't do any testing myself. I don't see how it could > possibly become worse than the current state of affairs. > > Many thanks, Lennart! Just trying to help get jessie released. -- Len Sorensen -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150304170147.gq25...@csclub.uwaterloo.ca
