Control: tag -1 - d-i + pending dann frazier <da...@debian.org> (2015-01-28): > Package: libdebian-installer4 > Version: 0.98 > Severity: serious > Tags: d-i patch > > The map_hardware[] table in src/system/subarch-arm-linux.c is no longer NULL > terminated. I believe this could lead to a segfault on armel/armhf platforms, > resulting in a failed install. > > This bug was introduced back in version 0.92. The end of the table was > trimmed, > and accidentally took the NULL terminator with it: > > http://anonscm.debian.org/cgit/d-i/libdebian-installer.git/commit/?id=3a7209e49fa5cfe8c4e4122325405022031a8afc > > DISCLAIMER: I haven't actually observed a crash, I just discovered this while > reviewing source. But it does seem like a potential time-bomb we should fix > pre-release. Here's the obvious patch: > > diff --git a/src/system/subarch-arm-linux.c b/src/system/subarch-arm-linux.c > index 590576a..3fc5e2a 100644 > --- a/src/system/subarch-arm-linux.c > +++ b/src/system/subarch-arm-linux.c > @@ -103,6 +103,7 @@ static struct map map_hardware[] = { > { "OMAP3 Beagle Board", "omap" }, > { "OMAP4 Panda Board", "omap" }, > { "ARM-Versatile Express", "vexpress" }, > + { NULL, NULL } > };
I was about to push it but you apparently already did; adjusting tags accordingly. Thanks! Mraw, KiBi.
signature.asc
Description: Digital signature
